Skip to content

Commit 09940fb

Browse files
show flow warnings and fixes all reported ones (#1832)
1 parent 09ed816 commit 09940fb

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

.flowconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
[libs]
1111

1212
[options]
13+
include_warnings=true
14+
module.use_strict=true
1315
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)?)\\)
1416
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)?)\\)?:? #[0-9]+
1517
suppress_comment=\\(.\\|\n\\)*\\$DisableFlowOnNegativeTest

src/type/__tests__/predicate-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,6 @@ describe('Directive predicates', () => {
605605
});
606606

607607
it('returns false for directive class (rather than instance)', () => {
608-
// $DisableFlowOnNegativeTest
609608
expect(isDirective(GraphQLDirective)).to.equal(false);
610609
expect(() => assertDirective(GraphQLDirective)).to.throw();
611610
});

src/utilities/__tests__/buildClientSchema-test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,6 @@ describe('Type System: build schema from introspection', () => {
548548
const introspection = introspectionFromSchema(dummySchema);
549549

550550
expect(introspection).to.have.nested.property('__schema.queryType.name');
551-
// $DisableFlowOnNegativeTest
552551
delete introspection.__schema.queryType.name;
553552

554553
expect(() => buildClientSchema(introspection)).to.throw(
@@ -705,7 +704,6 @@ describe('Type System: build schema from introspection', () => {
705704
name: 'SomeDirective',
706705
locations: ['QUERY'],
707706
});
708-
// $DisableFlowOnNegativeTest
709707
delete someDirectiveIntrospection.locations;
710708

711709
expect(() => buildClientSchema(introspection)).to.throw(
@@ -721,7 +719,6 @@ describe('Type System: build schema from introspection', () => {
721719
name: 'SomeDirective',
722720
args: [],
723721
});
724-
// $DisableFlowOnNegativeTest
725722
delete someDirectiveIntrospection.args;
726723

727724
expect(() => buildClientSchema(introspection)).to.throw(

0 commit comments

Comments
 (0)