Skip to content

Commit b73110d

Browse files
authored
Merge pull request #14 from Jannis/jannis/number-from-i32
Implement From<i32> for Number instead of From<i64>
2 parents e6c487c + 649d0c3 commit b73110d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/common.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ impl Number {
5858
}
5959
}
6060

61-
impl From<i64> for Number {
62-
fn from(i: i64) -> Self {
63-
Number(i)
61+
impl From<i32> for Number {
62+
fn from(i: i32) -> Self {
63+
Number(i as i64)
6464
}
6565
}
6666

@@ -265,10 +265,10 @@ mod tests {
265265
use super::Number;
266266

267267
#[test]
268-
fn number_and_i64_conversion() {
268+
fn number_from_i32_and_to_i64_conversion() {
269269
assert_eq!(Number::from(1).as_i64(), Some(1));
270270
assert_eq!(Number::from(584).as_i64(), Some(584));
271-
assert_eq!(Number::from(i64::min_value()).as_i64(), Some(i64::min_value()));
272-
assert_eq!(Number::from(i64::max_value()).as_i64(), Some(i64::max_value()));
271+
assert_eq!(Number::from(i32::min_value()).as_i64(), Some(i32::min_value() as i64));
272+
assert_eq!(Number::from(i32::max_value()).as_i64(), Some(i32::max_value() as i64));
273273
}
274274
}

0 commit comments

Comments
 (0)