Clippy

Author: tomhoule

examples/github/examples/github.rs

@@ -5,6 +5,7 @@ use prettytable::*;
 use serde::*;
 use structopt::StructOpt;
 
+#[allow(clippy::upper_case_acronyms)]
 type URI = String;
 
 #[derive(GraphQLQuery)]
@@ -79,16 +80,16 @@ fn main() -> Result<(), anyhow::Error> {
     table.set_format(*prettytable::format::consts::FORMAT_NO_LINESEP_WITH_TITLE);
     table.set_titles(row!(b => "issue", "comments"));
 
-    for issue in &response_data
+    for issue in response_data
         .repository
         .expect("missing repository")
         .issues
         .nodes
         .expect("issue nodes is null")
+        .iter()
+        .flatten()
     {
-        if let Some(issue) = issue {
-            table.add_row(row!(issue.title, issue.comments.total_count));
-        }
+        table.add_row(row!(issue.title, issue.comments.total_count));
     }
 
     table.printstd();

examples/web/examples/web.rs

@@ -98,22 +98,20 @@ fn render_response(response: graphql_client_web::Response<puppy_smiles::Response
         .map(|puppy| puppy.fullname_id.clone());
     LAST_ENTRY.lock().unwrap_throw().replace(new_cursor);
 
-    for puppy in &listings {
-        if let Some(puppy) = puppy {
-            write!(
-                inner_html,
-                r#"
+    for puppy in listings.iter().flatten() {
+        write!(
+            inner_html,
+            r#"
                     <div class="card" style="width: 26rem;">
                         <img class="img-thumbnail card-img-top" alt="{}" src="{}" />
                         <div class="card-body">
                             <h5 class="card-title">{}</h5>
                         </div>
                     </div>
                     "#,
-                puppy.title, puppy.url, puppy.title
-            )
-            .expect_throw("write to string");
-        }
+            puppy.title, puppy.url, puppy.title
+        )
+        .expect_throw("write to string");
     }
     response.set_inner_html(&format!(
         "<h2>response:</h2><div class=\"container\"><div class=\"row\">{}</div></div>",

graphql_client_cli/src/main.rs

@@ -107,15 +107,15 @@ fn main() -> anyhow::Result<()> {
             selected_operation,
             custom_scalars_module,
         } => generate::generate_code(generate::CliCodegenParams {
+            query_path,
+            schema_path,
+            selected_operation,
             variables_derives,
             response_derives,
             deprecation_strategy,
-            module_visibility,
             no_formatting,
+            module_visibility,
             output_directory,
-            query_path,
-            schema_path,
-            selected_operation,
             custom_scalars_module,
         }),
     }

graphql_client_codegen/src/query/selection.rs

@@ -131,13 +131,13 @@ impl SelectionParent {
         }
     }
 
-    pub(crate) fn to_path_segment(&self, query: &BoundQuery<'_>) -> String {
+    pub(crate) fn to_path_segment(self, query: &BoundQuery<'_>) -> String {
         match self {
             SelectionParent::Field(id) | SelectionParent::InlineFragment(id) => {
-                query.query.get_selection(*id).to_path_segment(query)
+                query.query.get_selection(id).to_path_segment(query)
             }
-            SelectionParent::Operation(id) => query.query.get_operation(*id).to_path_segment(),
-            SelectionParent::Fragment(id) => query.query.get_fragment(*id).to_path_segment(),
+            SelectionParent::Operation(id) => query.query.get_operation(id).to_path_segment(),
+            SelectionParent::Fragment(id) => query.query.get_fragment(id).to_path_segment(),
         }
     }
 }