Skip to content

Commit 7bfc590

Browse files
committed
Fix async processing messages
1 parent 84d5d17 commit 7bfc590

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

graphql_ws/aiohttp.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ async def _handle(self, ws, request_context=None):
4444
except ConnectionClosedException:
4545
break
4646

47-
connection_context.remember_task(
48-
self.on_message(connection_context, message), loop=self.loop
49-
)
47+
self.on_message(connection_context, message)
5048
await self.on_close(connection_context)
5149

5250
async def handle(self, ws, request_context=None):

graphql_ws/base_async.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ def closed(self):
8181
async def close(self, code):
8282
...
8383

84-
def remember_task(self, task, loop=None):
85-
self.pending_tasks.add(asyncio.ensure_future(task, loop=loop))
84+
def remember_task(self, task):
85+
self.pending_tasks.add(task)
8686
# Clear completed tasks
8787
self.pending_tasks -= WeakSet(
8888
task for task in self.pending_tasks if task.done()
@@ -102,9 +102,9 @@ async def handle(self, ws, request_context=None):
102102

103103
def process_message(self, connection_context, parsed_message):
104104
task = asyncio.ensure_future(
105-
super().process_message(connection_context, parsed_message)
105+
super().process_message(connection_context, parsed_message), loop=self.loop
106106
)
107-
connection_context.pending.add(task)
107+
connection_context.remember_task(task)
108108
return task
109109

110110
async def send_message(self, *args, **kwargs):

graphql_ws/websockets_lib.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ async def _handle(self, ws, request_context):
4040
except ConnectionClosedException:
4141
break
4242

43-
connection_context.remember_task(
44-
self.on_message(connection_context, message), loop=self.loop
45-
)
43+
self.on_message(connection_context, message)
4644
await self.on_close(connection_context)
4745

4846
async def handle(self, ws, request_context=None):

0 commit comments

Comments
 (0)