Skip to content

Commit 67fce02

Browse files
committed
Remove useless check since args are always array (can be empty)
Replicates graphql/graphql-js@bb07ecc
1 parent ea38577 commit 67fce02

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/graphql/execution/values.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ def get_argument_values(
119119
of argument AST nodes.
120120
"""
121121
coerced_values: Dict[str, Any] = {}
122-
arg_defs = type_def.args
123122
arg_nodes = node.arguments
124-
if not arg_defs or arg_nodes is None:
123+
if arg_nodes is None:
125124
return coerced_values
125+
arg_defs = type_def.args
126126
arg_node_map = {arg.name.value: arg for arg in arg_nodes}
127127
for name, arg_def in arg_defs.items():
128128
arg_type = arg_def.type

src/graphql/type/schema.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -281,10 +281,8 @@ def type_map_reducer(
281281

282282
if is_object_type(type_) or is_interface_type(type_):
283283
for field in cast(GraphQLInterfaceType, type_).fields.values():
284-
args = field.args
285-
if args:
286-
types = [arg.type for arg in args.values()]
287-
map_ = reduce(self.type_map_reducer, types, map_)
284+
types = [arg.type for arg in field.args.values()]
285+
map_ = reduce(self.type_map_reducer, types, map_)
288286
map_ = self.type_map_reducer(map_, field.type)
289287

290288
if is_input_object_type(type_):

0 commit comments

Comments
 (0)