Skip to content

Commit 2208c8e

Browse files
committed
Fix base class of field and input value definition nodes
These are only definition nodes, but not type definition nodes.
1 parent 3ddb4b6 commit 2208c8e

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

src/graphql/execution/values.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
DirectiveNode,
66
ExecutableDefinitionNode,
77
FieldNode,
8+
FieldDefinitionNode,
9+
InputValueDefinitionNode,
810
NullValueNode,
911
SchemaDefinitionNode,
1012
SelectionNode,
@@ -211,6 +213,8 @@ def get_argument_values(
211213

212214
NodeWithDirective = Union[
213215
ExecutableDefinitionNode,
216+
FieldDefinitionNode,
217+
InputValueDefinitionNode,
214218
SelectionNode,
215219
SchemaDefinitionNode,
216220
TypeDefinitionNode,

src/graphql/language/ast.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -513,16 +513,22 @@ class ObjectTypeDefinitionNode(TypeDefinitionNode):
513513
fields: Optional[FrozenList["FieldDefinitionNode"]]
514514

515515

516-
class FieldDefinitionNode(TypeDefinitionNode):
517-
__slots__ = "arguments", "type"
516+
class FieldDefinitionNode(DefinitionNode):
517+
__slots__ = "description", "name", "directives", "arguments", "type"
518518

519+
description: Optional[StringValueNode]
520+
name: NameNode
521+
directives: Optional[FrozenList[DirectiveNode]]
519522
arguments: Optional[FrozenList["InputValueDefinitionNode"]]
520523
type: TypeNode
521524

522525

523-
class InputValueDefinitionNode(TypeDefinitionNode):
524-
__slots__ = "type", "default_value"
526+
class InputValueDefinitionNode(DefinitionNode):
527+
__slots__ = "description", "name", "directives", "type", "default_value"
525528

529+
description: Optional[StringValueNode]
530+
name: NameNode
531+
directives: Optional[FrozenList[DirectiveNode]]
526532
type: TypeNode
527533
default_value: Optional[ValueNode]
528534

tests/language/test_predicates.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,8 @@ def check_type_system_definition_node():
101101
"enum_type_definition",
102102
"enum_type_extension",
103103
"enum_value_definition",
104-
"field_definition",
105104
"input_object_type_definition",
106105
"input_object_type_extension",
107-
"input_value_definition",
108106
"interface_type_definition",
109107
"interface_type_extension",
110108
"object_type_definition",
@@ -123,9 +121,7 @@ def check_type_definition_node():
123121
assert filter_nodes(is_type_definition_node) == [
124122
"enum_type_definition",
125123
"enum_value_definition",
126-
"field_definition",
127124
"input_object_type_definition",
128-
"input_value_definition",
129125
"interface_type_definition",
130126
"object_type_definition",
131127
"scalar_type_definition",

0 commit comments

Comments
 (0)