Move variable definition directive off of experimental flag

Replicates graphql/graphql-js@252e737

Author: Cito

graphql/language/parser.py

@@ -66,10 +66,7 @@
 
 
 def parse(
-    source: SourceType,
-    no_location=False,
-    experimental_fragment_variables=False,
-    experimental_variable_definition_directives=False,
+    source: SourceType, no_location=False, experimental_fragment_variables=False
 ) -> DocumentNode:
     """Given a GraphQL source, parse it into a Document.
 
@@ -90,13 +87,6 @@ def parse(
         fragment A($var: Boolean = false) on T  {
           ...
         }
-
-    If `experimental_variable_definition_directives` is set to True, the parser
-    understands directives on variable definitions::
-
-        query Foo($var: String = "abc" @variable_definition_directive) {
-          ...
-        }
     """
     if isinstance(source, str):
         source = Source(source)
@@ -106,9 +96,6 @@ def parse(
         source,
         no_location=no_location,
         experimental_fragment_variables=experimental_fragment_variables,
-        experimental_variable_definition_directives=(
-            experimental_variable_definition_directives
-        ),
     )
     return parse_document(lexer)
 
@@ -246,22 +233,13 @@ def parse_variable_definitions(lexer: Lexer) -> List[VariableDefinitionNode]:
 def parse_variable_definition(lexer: Lexer) -> VariableDefinitionNode:
     """VariableDefinition: Variable: Type DefaultValue? Directives[Const]?"""
     start = lexer.token
-    if lexer.experimental_variable_definition_directives:
-        return VariableDefinitionNode(
-            variable=parse_variable(lexer),
-            type=expect(lexer, TokenKind.COLON) and parse_type_reference(lexer),
-            default_value=parse_value_literal(lexer, True)
-            if skip(lexer, TokenKind.EQUALS)
-            else None,
-            directives=parse_directives(lexer, True),
-            loc=loc(lexer, start),
-        )
     return VariableDefinitionNode(
         variable=parse_variable(lexer),
         type=expect(lexer, TokenKind.COLON) and parse_type_reference(lexer),
         default_value=parse_value_literal(lexer, True)
         if skip(lexer, TokenKind.EQUALS)
         else None,
+        directives=parse_directives(lexer, True),
         loc=loc(lexer, start),
     )
 

tests/language/test_parser.py

@@ -105,11 +105,8 @@ def parses_constant_default_values():
             (1, 37),
         )
 
-    def experimental_parses_variable_definition_directives():
-        parse(
-            "query Foo($x: Boolean = false @bar) { field }",
-            experimental_variable_definition_directives=True,
-        )
+    def parses_variable_definition_directives():
+        parse("query Foo($x: Boolean = false @bar) { field }")
 
     def does_not_accept_fragments_named_on():
         assert_syntax_error("fragment on on on { on }", "Unexpected Name 'on'", (1, 10))

tests/language/test_printer.py

@@ -64,11 +64,9 @@ def correctly_prints_mutation_operation_with_artifacts():
             """
         )
 
-    def experimental_prints_query_with_variable_directives():
+    def prints_query_with_variable_directives():
         query_ast_with_variable_directive = parse(
-            "query ($foo: TestType = {a: 123}"
-            " @testDirective(if: true) @test) { id }",
-            experimental_variable_definition_directives=True,
+            "query ($foo: TestType = {a: 123}" " @testDirective(if: true) @test) { id }"
         )
         assert print_ast(query_ast_with_variable_directive) == dedent(
             """
@@ -82,7 +80,6 @@ def experimental_prints_fragment_with_variable_directives():
         query_ast_with_variable_directive = parse(
             "fragment Foo($foo: TestType @test) on TestType @testDirective { id }",
             experimental_fragment_variables=True,
-            experimental_variable_definition_directives=True,
         )
         assert print_ast(query_ast_with_variable_directive) == dedent(
             """

tests/validation/test_known_directives.py

@@ -127,15 +127,14 @@ def with_well_placed_directives():
             """,
         )
 
-    def experimental_with_well_placed_variable_definition_directive():
+    def with_well_placed_variable_definition_directive():
         expect_passes_rule(
             KnownDirectivesRule,
             """
             query Foo($var: Boolean @onVariableDefinition) {
               name
             }
             """,
-            experimental_variable_definition_directives=True,
         )
 
     def with_misplaced_directives():
@@ -159,7 +158,7 @@ def with_misplaced_directives():
             ],
         )
 
-    def experimental_with_misplaced_variable_definition_directive():
+    def with_misplaced_variable_definition_directive():
         expect_fails_rule(
             KnownDirectivesRule,
             """
@@ -168,7 +167,6 @@ def experimental_with_misplaced_variable_definition_directive():
             }
             """,
             [misplaced_directive("onField", "variable definition", 2, 37)],
-            experimental_variable_definition_directives=True,
         )
 
     def describe_within_sdl():