diff --git a/README.md b/README.md index 04d66456..af2c38a7 100644 --- a/README.md +++ b/README.md @@ -114,20 +114,37 @@ from graphql.execution.execute import execute execute(schema, ast, executor=SyncExecutor()) ``` -### Development +### Contributing -Install development and test dependencies: +After cloning this repo, create a [virtualenv](https://virtualenv.pypa.io/en/stable/) and ensure dependencies are installed by running: ```sh +virtualenv venv +source venv/bin/activate pip install -e ".[test]" ``` -Run test suite: +Well-written tests and maintaining good test coverage is important to this project. While developing, run new and existing tests with: ```sh -pytest +py.test PATH/TO/MY/DIR/test_test.py # Single file +py.test PATH/TO/MY/DIR/ # All tests in directory ``` +Add the `-s` flag if you have introduced breakpoints into the code for debugging. +Add the `-v` ("verbose") flag to get more detailed test output. For even more detailed output, use `-vv`. +Check out the [pytest documentation](https://docs.pytest.org/en/latest/) for more options and test running controls. + +GraphQL-core supports several versions of Python. To make sure that changes do not break compatibility with any of those versions, we use `tox` to create virtualenvs for each python version and run tests with that version. To run against all python versions defined in the `tox.ini` config file, just run: +```sh +tox +``` +If you wish to run against a specific version defined in the `tox.ini` file: +```sh +tox -e py36 +``` +Tox can only use whatever versions of python are installed on your system. When you create a pull request, Travis will also be running the same tests and report the results, so there is no need for potential contributors to try to install every single version of python on their own system ahead of time. We appreciate opening issues and pull requests to make GraphQL-core even more stable & useful! + ## Main Contributors * [@syrusakbary](https://github.com/syrusakbary/)