Allow nested objects with similar keys.

Closes #34

Author: jhgg

graphql/core/validation/rules/unique_input_field_names.py

@@ -3,15 +3,20 @@
 
 
 class UniqueInputFieldNames(ValidationRule):
-    __slots__ = 'known_names',
+    __slots__ = 'known_names', 'known_names_stack'
 
     def __init__(self, context):
         super(UniqueInputFieldNames, self).__init__(context)
         self.known_names = {}
+        self.known_names_stack = []
 
     def enter_ObjectValue(self, node, key, parent, path, ancestors):
+        self.known_names_stack.append(self.known_names)
         self.known_names = {}
 
+    def leave_ObjectValue(self, node, key, parent, path, ancestors):
+        self.known_names = self.known_names_stack.pop()
+
     def enter_ObjectField(self, node, key, parent, path, ancestors):
         field_name = node.name.value
         if field_name in self.known_names:

tests/core_validation/test_unique_input_field_names.py

@@ -34,6 +34,22 @@ def test_multiple_input_object_fields():
     ''')
 
 
+def test_it_allows_for_nested_input_objects_with_similar_fields():
+    expect_passes_rule(UniqueInputFieldNames, '''
+    {
+        field(arg: {
+            deep: {
+              deep: {
+                id: 1
+            }
+            id: 1
+            }
+            id: 1
+        })
+    }
+    ''')
+
+
 def test_duplicate_input_object_fields():
     expect_fails_rule(UniqueInputFieldNames, '''
     {
@@ -52,4 +68,4 @@ def test_many_duplicate_input_object_fields():
     ''', [
         duplicate_field('f1', L(3, 22), L(3, 35)),
         duplicate_field('f1', L(3, 22), L(3, 48))
-    ])
+    ])