Validation: context.getFragmentSpreads now accepts selectionSet rather than fragment AST node. Commit: graphql/graphql-js@688a1ee

Author: markusdap

graphql/validation/rules/no_fragment_cycles.py

@@ -24,7 +24,7 @@ def detect_cycle_recursive(self, fragment):
         fragment_name = fragment.name.value
         self.visited_frags.add(fragment_name)
 
-        spread_nodes = self.context.get_fragment_spreads(fragment)
+        spread_nodes = self.context.get_fragment_spreads(fragment.selection_set)
         if not spread_nodes:
             return
 

graphql/validation/validation.py

@@ -96,7 +96,7 @@ def get_recursively_referenced_fragments(self, operation):
         if not fragments:
             fragments = []
             collected_names = set()
-            nodes_to_visit = [operation]
+            nodes_to_visit = [operation.selection_set]
             while nodes_to_visit:
                 node = nodes_to_visit.pop()
                 spreads = self.get_fragment_spreads(node)
@@ -107,15 +107,15 @@ def get_recursively_referenced_fragments(self, operation):
                         fragment = self.get_fragment(frag_name)
                         if fragment:
                             fragments.append(fragment)
-                            nodes_to_visit.append(fragment)
+                            nodes_to_visit.append(fragment.selection_set)
             self._recursively_referenced_fragments[operation] = fragments
         return fragments
 
     def get_fragment_spreads(self, node):
         spreads = self._fragment_spreads.get(node)
         if not spreads:
             spreads = []
-            sets_to_visit = [node.selection_set]
+            sets_to_visit = [node]
             while sets_to_visit:
                 _set = sets_to_visit.pop()
                 for selection in _set.selections: