From 15b1a8d66003c893fdae2560748e937659f41eb4 Mon Sep 17 00:00:00 2001 From: Greg Svitak Date: Sun, 25 Sep 2016 13:55:43 -0400 Subject: [PATCH 1/3] adding support to convert int label columns similar to PR#2 --- graphene_sqlalchemy/converter.py | 3 ++- graphene_sqlalchemy/tests/test_converter.py | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/graphene_sqlalchemy/converter.py b/graphene_sqlalchemy/converter.py index 05690697..97bf1267 100644 --- a/graphene_sqlalchemy/converter.py +++ b/graphene_sqlalchemy/converter.py @@ -101,7 +101,8 @@ def convert_column_to_int_or_id(type, column, registry=None): if column.primary_key: return ID(description=column.doc, required=not(column.nullable)) else: - return Int(description=column.doc, required=not(column.nullable)) + return Int(description=getattr(column, 'doc', None), + required=not(getattr(column, 'nullable', True))) @convert_sqlalchemy_type.register(types.Boolean) diff --git a/graphene_sqlalchemy/tests/test_converter.py b/graphene_sqlalchemy/tests/test_converter.py index 0157f837..dd671d48 100644 --- a/graphene_sqlalchemy/tests/test_converter.py +++ b/graphene_sqlalchemy/tests/test_converter.py @@ -113,6 +113,11 @@ def test_should_label_convert_string(): assert isinstance(graphene_type, graphene.String) +def test_should_label_convert_int(): + label = Label('int_label_test', case([], else_="foo"), type_=types.Integer()) + graphene_type = convert_sqlalchemy_column(label) + assert isinstance(graphene_type, graphene.Int) + def test_should_choice_convert_enum(): TYPES = [ (u'es', u'Spanish'), From 1b3c6c287c5d31d9361308f23bfaece91c476dd9 Mon Sep 17 00:00:00 2001 From: Greg Svitak Date: Sun, 25 Sep 2016 14:05:36 -0400 Subject: [PATCH 2/3] fix for pep --- graphene_sqlalchemy/converter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphene_sqlalchemy/converter.py b/graphene_sqlalchemy/converter.py index 97bf1267..073a6dc6 100644 --- a/graphene_sqlalchemy/converter.py +++ b/graphene_sqlalchemy/converter.py @@ -102,7 +102,7 @@ def convert_column_to_int_or_id(type, column, registry=None): return ID(description=column.doc, required=not(column.nullable)) else: return Int(description=getattr(column, 'doc', None), - required=not(getattr(column, 'nullable', True))) + required=not(getattr(column, 'nullable', True))) @convert_sqlalchemy_type.register(types.Boolean) From 05fac7d7ced8bb60924f327ab7d10543d108a6aa Mon Sep 17 00:00:00 2001 From: Greg Svitak Date: Sun, 25 Sep 2016 14:15:42 -0400 Subject: [PATCH 3/3] fixes for pep --- graphene_sqlalchemy/converter.py | 4 ++-- graphene_sqlalchemy/tests/test_converter.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/graphene_sqlalchemy/converter.py b/graphene_sqlalchemy/converter.py index 073a6dc6..0c8f53ba 100644 --- a/graphene_sqlalchemy/converter.py +++ b/graphene_sqlalchemy/converter.py @@ -99,10 +99,10 @@ def convert_column_to_string(type, column, registry=None): @convert_sqlalchemy_type.register(types.Integer) def convert_column_to_int_or_id(type, column, registry=None): if column.primary_key: - return ID(description=column.doc, required=not(column.nullable)) + return ID(description=column.doc, required=not (column.nullable)) else: return Int(description=getattr(column, 'doc', None), - required=not(getattr(column, 'nullable', True))) + required=not (getattr(column, 'nullable', True))) @convert_sqlalchemy_type.register(types.Boolean) diff --git a/graphene_sqlalchemy/tests/test_converter.py b/graphene_sqlalchemy/tests/test_converter.py index dd671d48..8ec2283c 100644 --- a/graphene_sqlalchemy/tests/test_converter.py +++ b/graphene_sqlalchemy/tests/test_converter.py @@ -114,9 +114,9 @@ def test_should_label_convert_string(): def test_should_label_convert_int(): - label = Label('int_label_test', case([], else_="foo"), type_=types.Integer()) - graphene_type = convert_sqlalchemy_column(label) - assert isinstance(graphene_type, graphene.Int) + label = Label('int_label_test', case([], else_="foo"), type_=types.Integer()) + graphene_type = convert_sqlalchemy_column(label) + assert isinstance(graphene_type, graphene.Int) def test_should_choice_convert_enum(): TYPES = [