From 8ba849b65fd9c9494644d768341ed9505b05c20f Mon Sep 17 00:00:00 2001 From: Palm Kevin Date: Fri, 28 Oct 2016 07:23:46 +0200 Subject: [PATCH 1/3] convert biginteger to float Biginteger can be too big for integer because integer is limited to 32 bit --- graphene_sqlalchemy/converter.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/graphene_sqlalchemy/converter.py b/graphene_sqlalchemy/converter.py index 05690697..c37311bc 100644 --- a/graphene_sqlalchemy/converter.py +++ b/graphene_sqlalchemy/converter.py @@ -95,7 +95,7 @@ def convert_column_to_string(type, column, registry=None): @convert_sqlalchemy_type.register(types.SmallInteger) -@convert_sqlalchemy_type.register(types.BigInteger) +#@convert_sqlalchemy_type.register(types.BigInteger) @convert_sqlalchemy_type.register(types.Integer) def convert_column_to_int_or_id(type, column, registry=None): if column.primary_key: @@ -111,6 +111,7 @@ def convert_column_to_boolean(type, column, registry=None): @convert_sqlalchemy_type.register(types.Float) @convert_sqlalchemy_type.register(types.Numeric) +@convert_sqlalchemy_type.register(types.BigInteger) def convert_column_to_float(type, column, registry=None): return Float(description=column.doc, required=not(column.nullable)) From 8f0fb84779e2cbc2f52daba5fe7fb8a7d715f3ce Mon Sep 17 00:00:00 2001 From: Palm Kevin Date: Fri, 18 Nov 2016 08:47:46 +0100 Subject: [PATCH 2/3] Removed commeted BigInteger-int-mapping line --- graphene_sqlalchemy/converter.py | 1 - 1 file changed, 1 deletion(-) diff --git a/graphene_sqlalchemy/converter.py b/graphene_sqlalchemy/converter.py index c37311bc..96a62b90 100644 --- a/graphene_sqlalchemy/converter.py +++ b/graphene_sqlalchemy/converter.py @@ -95,7 +95,6 @@ def convert_column_to_string(type, column, registry=None): @convert_sqlalchemy_type.register(types.SmallInteger) -#@convert_sqlalchemy_type.register(types.BigInteger) @convert_sqlalchemy_type.register(types.Integer) def convert_column_to_int_or_id(type, column, registry=None): if column.primary_key: From f83e4060c25908e9773e07820435526514368a7e Mon Sep 17 00:00:00 2001 From: Palm Kevin Date: Fri, 18 Nov 2016 16:20:38 +0100 Subject: [PATCH 3/3] Adapted the test in order to check convertin to float --- graphene_sqlalchemy/tests/test_converter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphene_sqlalchemy/tests/test_converter.py b/graphene_sqlalchemy/tests/test_converter.py index 0157f837..f92cac71 100644 --- a/graphene_sqlalchemy/tests/test_converter.py +++ b/graphene_sqlalchemy/tests/test_converter.py @@ -84,7 +84,7 @@ def test_should_small_integer_convert_int(): def test_should_big_integer_convert_int(): - assert_column_conversion(types.BigInteger(), graphene.Int) + assert_column_conversion(types.BigInteger(), graphene.Float) def test_should_integer_convert_int():