add tests

Author: Maxim Romanyuk

graphene_sqlalchemy/converter.py

@@ -1,3 +1,5 @@
+from enum import EnumMeta
+
 from singledispatch import singledispatch
 from sqlalchemy import types
 from sqlalchemy.dialects import postgresql
@@ -7,7 +9,6 @@
                       String)
 from graphene.types.json import JSONString
 
-from enum import EnumMeta
 from .enums import enum_for_sa_enum
 from .registry import get_global_registry
 
@@ -160,7 +161,6 @@ def convert_enum_to_enum(type, column, registry=None):
     return lambda: enum_for_sa_enum(type, registry or get_global_registry())
 
 
-# TODO Make ChoiceType conversion consistent with other enums
 @convert_sqlalchemy_type.register(ChoiceType)
 def convert_choice_to_enum(type, column, registry=None):
     name = "{}_{}".format(column.table.name, column.name).upper()

graphene_sqlalchemy/tests/test_converter.py

@@ -145,6 +145,32 @@ def test_should_choice_convert_enum():
     assert graphene_type._meta.enum.__members__["en"].value == "English"
 
 
+def test_should_enum_choice_convert_enum():
+    class TestEnum(enum.Enum):
+        es = u"Spanish"
+        en = u"English"
+
+    field = get_field(ChoiceType(TestEnum, impl=types.String()))
+    graphene_type = field.type
+    assert issubclass(graphene_type, graphene.Enum)
+    assert graphene_type._meta.name == "MODEL_COLUMN"
+    assert graphene_type._meta.enum.__members__["es"].value == "Spanish"
+    assert graphene_type._meta.enum.__members__["en"].value == "English"
+
+
+def test_should_intenum_choice_convert_enum():
+    class TestEnum(enum.IntEnum):
+        one = 1
+        two = 2
+
+    field = get_field(ChoiceType(TestEnum, impl=types.String()))
+    graphene_type = field.type
+    assert issubclass(graphene_type, graphene.Enum)
+    assert graphene_type._meta.name == "MODEL_COLUMN"
+    assert graphene_type._meta.enum.__members__["one"].value == 1
+    assert graphene_type._meta.enum.__members__["two"].value == 2
+
+
 def test_should_columproperty_convert():
     field = get_field_from_column(column_property(
         select([func.sum(func.cast(id, types.Integer))]).where(id == 1)