Skip to content

Commit 9a45d60

Browse files
authored
Update converter.py
When using reflection to build the models (instead of declarative) the Enum conversion fails because the ENUM column is treated as string so doing type.name returns None. ```sql CREATE TABLE `foos` ( `id` int(11) unsigned NOT NULL AUTO_INCREMENT, `status` ENUM('open', 'closed') DEFAULT 'open', PRIMARY KEY (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; ``` ```python class Foo(Base): __table__ = Table('foos', metadata, autoload=True) ```
1 parent 8872577 commit 9a45d60

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

graphene_sqlalchemy/converter.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,11 @@ def convert_enum_to_enum(type, column, registry=None):
150150
items = type.enum_class.__members__.items()
151151
except AttributeError:
152152
items = zip(type.enums, type.enums)
153+
154+
enum_name = type.name or "{}_{}".format(column.table, column.name)
155+
153156
return Field(
154-
Enum(type.name, items),
157+
Enum(enum_name, items),
155158
description=get_column_doc(column),
156159
required=not (is_column_nullable(column)),
157160
)

0 commit comments

Comments
 (0)