Skip to content

Commit 8080232

Browse files
authored
Merge pull request #20 from palmkevin/DateTime
graphene type DateTime should used for sqlalchemy type DateTime
2 parents c07b746 + ca51c21 commit 8080232

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

graphene_sqlalchemy/converter.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ def convert_sqlalchemy_type(type, column, registry=None):
8181

8282

8383
@convert_sqlalchemy_type.register(types.Date)
84-
@convert_sqlalchemy_type.register(types.DateTime)
8584
@convert_sqlalchemy_type.register(types.Time)
8685
@convert_sqlalchemy_type.register(types.String)
8786
@convert_sqlalchemy_type.register(types.Text)
@@ -95,6 +94,13 @@ def convert_column_to_string(type, column, registry=None):
9594
required=not(getattr(column, 'nullable', True)))
9695

9796

97+
@convert_sqlalchemy_type.register(types.DateTime)
98+
def convert_column_to_datetime(type, column, registry=None):
99+
from graphene.types.datetime import DateTime
100+
return DateTime(description=getattr(column, 'doc', None),
101+
required=not(getattr(column, 'nullable', True)))
102+
103+
98104
@convert_sqlalchemy_type.register(types.SmallInteger)
99105
@convert_sqlalchemy_type.register(types.BigInteger)
100106
@convert_sqlalchemy_type.register(types.Integer)

graphene_sqlalchemy/tests/test_converter.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
import graphene
1010
from graphene.relay import Node
11+
from graphene.types.datetime import DateTime
1112
from graphene.types.json import JSONString
1213

1314
from ..converter import (convert_sqlalchemy_column,
@@ -52,7 +53,7 @@ def test_should_date_convert_string():
5253

5354

5455
def test_should_datetime_convert_string():
55-
assert_column_conversion(types.DateTime(), graphene.String)
56+
assert_column_conversion(types.DateTime(), DateTime)
5657

5758

5859
def test_should_time_convert_string():

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
'graphene>=1.0',
3737
'SQLAlchemy',
3838
'singledispatch>=3.4.0.3',
39+
'iso8601',
3940
],
4041
tests_require=[
4142
'pytest>=2.7.2',

0 commit comments

Comments
 (0)