Add note about insufficient test

Cito · Cito · commit 609c5611f83c · 2019-05-05T18:54:18.000+02:00
diff --git a/graphene_sqlalchemy/tests/test_sort_enums.py b/graphene_sqlalchemy/tests/test_sort_enums.py
@@ -381,6 +381,9 @@ def makeNodes(nodeList):
 
     result = schema.execute(queryNoSort, context_value={"session": session})
     assert not result.errors
+    # TODO: SQLite usually returns the results ordered by primary key,
+    # so we cannot test this way whether sorting actually happens or not.
+    # Also, no sort order is guaranteed by SQLite if "no order" by is used.
     assert [node["node"]["name"] for node in result.data["noSort"]["edges"]] == [
         node["node"]["name"] for node in result.data["noDefaultSort"]["edges"]
     ]

Original file line number	Diff line number	Diff line change
`@@ -381,6 +381,9 @@ def makeNodes(nodeList):`
`381`	`381`
`382`	`382`	`result = schema.execute(queryNoSort, context_value={"session": session})`
`383`	`383`	`assert not result.errors`
	`384`	`+ # TODO: SQLite usually returns the results ordered by primary key,`
	`385`	`+ # so we cannot test this way whether sorting actually happens or not.`
	`386`	`+ # Also, no sort order is guaranteed by SQLite if "no order" by is used.`
`384`	`387`	`assert [node["node"]["name"] for node in result.data["noSort"]["edges"]] == [`
`385`	`388`	`node["node"]["name"] for node in result.data["noDefaultSort"]["edges"]`
`386`	`389`	`]`