From d40ede92acdb82c70a43fe79db2bb46b1c7a4ff6 Mon Sep 17 00:00:00 2001 From: femesq Date: Fri, 3 Feb 2017 21:59:07 -0200 Subject: [PATCH 1/2] Exception raises when GET request is sent to batch endpoint Was getting: ``` ValueError at /graphql/batch/ max() arg is an empty sequence ``` --- graphene_django/views.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/graphene_django/views.py b/graphene_django/views.py index a68fd5344..5431caafc 100644 --- a/graphene_django/views.py +++ b/graphene_django/views.py @@ -105,8 +105,11 @@ def dispatch(self, request, *args, **kwargs): if self.batch: responses = [self.get_response(request, entry) for entry in data] - result = '[{}]'.format(','.join([response[0] for response in responses])) - status_code = max(responses, key=lambda response: response[1])[1] + if not responses: + result, status_code = self.get_response(request, data, show_graphiql) + else: + result = '[{}]'.format(','.join([response[0] for response in responses])) + status_code = max(responses, key=lambda response: response[1])[1] else: result, status_code = self.get_response(request, data, show_graphiql) From e66960507e19d2a192630fcd76f16bea9306328d Mon Sep 17 00:00:00 2001 From: femesq Date: Mon, 13 Feb 2017 11:37:52 -0200 Subject: [PATCH 2/2] Update views.py --- graphene_django/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphene_django/views.py b/graphene_django/views.py index 5431caafc..409a2e5a3 100644 --- a/graphene_django/views.py +++ b/graphene_django/views.py @@ -106,7 +106,7 @@ def dispatch(self, request, *args, **kwargs): if self.batch: responses = [self.get_response(request, entry) for entry in data] if not responses: - result, status_code = self.get_response(request, data, show_graphiql) + result, status_code = self.get_response(request, data, show_graphiql) else: result = '[{}]'.format(','.join([response[0] for response in responses])) status_code = max(responses, key=lambda response: response[1])[1]