Skip to content

Commit cc58b91

Browse files
committed
fix SerializerMutation regression for 2.x
72529b7 seems to break SerializerMutation by commenting out support for input fields. As a result input only ever had a clientMutationId field.
1 parent 9cac83b commit cc58b91

File tree

3 files changed

+20
-6
lines changed

3 files changed

+20
-6
lines changed

graphene_django/rest_framework/mutation.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ def __init_subclass_with_meta__(cls, serializer_class=None,
5555
output_fields = fields_for_serializer(serializer, only_fields, exclude_fields, is_input=False)
5656

5757
_meta = SerializerMutationOptions(cls)
58+
_meta.serializer_class = serializer_class
5859
_meta.fields = yank_fields_from_attrs(
5960
output_fields,
6061
_as=Field,

graphene_django/rest_framework/serializer_converter.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ def convert_serializer_field(field, is_input=True):
4242

4343
if isinstance(field, serializers.ModelSerializer):
4444
if is_input:
45-
return Dynamic(lambda: None)
46-
# graphql_type = convert_serializer_to_input_type(field.__class__)
45+
graphql_type = convert_serializer_to_input_type(field.__class__)
4746
else:
4847
global_registry = get_global_registry()
4948
field_model = field.Meta.model
@@ -52,6 +51,21 @@ def convert_serializer_field(field, is_input=True):
5251
return graphql_type(*args, **kwargs)
5352

5453

54+
def convert_serializer_to_input_type(serializer_class):
55+
serializer = serializer_class()
56+
57+
items = {
58+
name: convert_serializer_field(field)
59+
for name, field in serializer.fields.items()
60+
}
61+
62+
return type(
63+
'{}Input'.format(serializer.__class__.__name__),
64+
(graphene.InputObjectType,),
65+
items
66+
)
67+
68+
5569
@get_graphene_type_from_serializer_field.register(serializers.Field)
5670
def convert_serializer_field_to_string(field):
5771
return graphene.String

graphene_django/rest_framework/tests/test_mutation.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ class Meta:
6565
assert model_field.type == MyFakeModelGrapheneType
6666

6767
model_input = MyMutation.Input._meta.fields['model']
68-
model_input_type = model_input.get_type()
69-
assert not model_input_type
70-
# assert issubclass(model_input_type, InputObjectType)
71-
# assert 'cool_name' in model_input_type._meta.fields
68+
model_input_type = model_input._type.of_type
69+
assert issubclass(model_input_type, InputObjectType)
70+
assert 'cool_name' in model_input_type._meta.fields

0 commit comments

Comments
 (0)