Skip to content

Commit 316b4a5

Browse files
committed
Cleanup some flake8 warnings and pytest warnings
1 parent 5532e89 commit 316b4a5

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

graphene_django/filter/tests/test_fields.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ class context(object):
183183
}
184184
"""
185185
schema = Schema(query=Query)
186-
result = schema.execute(query, context_value=context())
186+
result = schema.execute(query, context=context())
187187
assert not result.errors
188188

189189
assert len(result.data["contextArticles"]["edges"]) == 1
@@ -321,12 +321,14 @@ class Query(ObjectType):
321321
pub_date=datetime.now(),
322322
pub_date_time=datetime.now(),
323323
reporter=r1,
324+
editor=r1,
324325
)
325326
Article.objects.create(
326327
headline="a2",
327328
pub_date=datetime.now(),
328329
pub_date_time=datetime.now(),
329330
reporter=r2,
331+
editor=r1,
330332
)
331333

332334
query = """
@@ -450,7 +452,7 @@ class Meta:
450452
assert multiple_filter.field_class == GlobalIDMultipleChoiceField
451453

452454

453-
def test_filter_filterset_related_results():
455+
def test_filter_filterset_related_results_with_filter():
454456
class ReporterFilterNode(DjangoObjectType):
455457
class Meta:
456458
model = Reporter
@@ -460,15 +462,15 @@ class Meta:
460462
class Query(ObjectType):
461463
all_reporters = DjangoFilterConnectionField(ReporterFilterNode)
462464

463-
r1 = Reporter.objects.create(
465+
Reporter.objects.create(
464466
first_name="A test user", last_name="Last Name", email="test1@test.com"
465467
)
466-
r2 = Reporter.objects.create(
468+
Reporter.objects.create(
467469
first_name="Other test user",
468470
last_name="Other Last Name",
469471
email="test2@test.com",
470472
)
471-
r3 = Reporter.objects.create(
473+
Reporter.objects.create(
472474
first_name="Random", last_name="RandomLast", email="random@test.com"
473475
)
474476

@@ -636,7 +638,7 @@ def resolve_all_reporters(self, info, **args):
636638
Reporter.objects.create(
637639
first_name="Bob", last_name="Doe", email="bobdoe@example.com", a_choice=2
638640
)
639-
r = Reporter.objects.create(
641+
Reporter.objects.create(
640642
first_name="John", last_name="Doe", email="johndoe@example.com", a_choice=1
641643
)
642644

@@ -682,7 +684,7 @@ def resolve_all_reporters(self, info, reverse_order=False, **args):
682684
return reporters
683685

684686
Reporter.objects.create(first_name="b")
685-
r = Reporter.objects.create(first_name="a")
687+
Reporter.objects.create(first_name="a")
686688

687689
schema = Schema(query=Query)
688690
query = """

0 commit comments

Comments
 (0)