Skip to content

Commit 04f5770

Browse files
committed
Move check for distinct into merge_querysets; cleanup
1 parent 86385d1 commit 04f5770

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

graphene_django/fields.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ def get_manager(self):
5757

5858
@classmethod
5959
def merge_querysets(cls, default_queryset, queryset):
60+
if default_queryset.query.distinct and not queryset.query.distinct:
61+
queryset = queryset.distinct()
62+
elif queryset.query.distinct and not default_queryset.query.distinct:
63+
default_queryset = default_queryset.distinct()
6064
return default_queryset & queryset
6165

6266
@classmethod
@@ -90,10 +94,6 @@ def connection_resolver(cls, resolver, connection, default_manager, max_limit,
9094
if isinstance(iterable, QuerySet):
9195
if iterable is not default_manager:
9296
default_queryset = maybe_queryset(default_manager)
93-
if default_queryset.query.distinct and not iterable.query.distinct:
94-
iterable = iterable.distinct()
95-
elif iterable.query.distinct and not default_queryset.query.distinct:
96-
default_queryset = default_queryset.distinct()
9797
iterable = cls.merge_querysets(default_queryset, iterable)
9898
_len = iterable.count()
9999
else:

graphene_django/tests/test_query.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,6 @@ def resolve_films(self, args, context, info):
419419

420420
result = schema.execute(query)
421421
assert not result.errors
422-
print(result.data)
423422
assert result.data == expected
424423

425424

0 commit comments

Comments
 (0)