Really Fix nested input arguments this time

Author: leszekhanusz

gql/dsl.py

@@ -1,6 +1,6 @@
 import logging
 from collections.abc import Iterable
-from typing import Any, Callable, Dict, List, Optional, Union, cast
+from typing import Any, Callable, List, Optional, Union, cast
 
 from graphql import (
     ArgumentNode,
@@ -212,9 +212,6 @@ def __init__(
         self.ast_field: FieldNode = FieldNode(
             name=NameNode(value=name), arguments=FrozenList()
         )
-        self.known_arg_serializers: Dict[
-            GraphQLInputType, Optional[Serializer]
-        ] = dict()
         log.debug(f"Creating {self!r}")
 
     @staticmethod
@@ -343,19 +340,19 @@ def _get_arg_serializer(self, arg_type: GraphQLInputType) -> Serializer:
             return self._get_arg_serializer(arg_type.of_type)
 
         elif isinstance(arg_type, GraphQLInputObjectType):
-            if arg_type in self.known_arg_serializers:
-                return cast(Serializer, self.known_arg_serializers[arg_type])
-            self.known_arg_serializers[arg_type] = None
-            serializers = {
-                k: self._get_arg_serializer(v.type) for k, v in arg_type.fields.items()
-            }
-            self.known_arg_serializers[arg_type] = lambda value: ObjectValueNode(
+            return lambda value: ObjectValueNode(
                 fields=FrozenList(
-                    ObjectFieldNode(name=NameNode(value=k), value=serializers[k](v))
+                    ObjectFieldNode(
+                        name=NameNode(value=k),
+                        value=(
+                            self._get_arg_serializer(
+                                cast(GraphQLInputObjectType, arg_type).fields[k].type
+                            )
+                        )(v),
+                    )
                     for k, v in value.items()
                 )
             )
-            return cast(Serializer, self.known_arg_serializers[arg_type])
 
         elif isinstance(arg_type, GraphQLList):
             inner_serializer = self._get_arg_serializer(arg_type.of_type)

tests/nested_input/schema.py

@@ -1,3 +1,5 @@
+import json
+
 from graphql import (
     GraphQLArgument,
     GraphQLField,
@@ -6,6 +8,7 @@
     GraphQLInt,
     GraphQLObjectType,
     GraphQLSchema,
+    GraphQLString,
 )
 
 nestedInput = GraphQLInputObjectType(
@@ -19,10 +22,10 @@
 queryType = GraphQLObjectType(
     "Query",
     fields=lambda: {
-        "foo": GraphQLField(
+        "echo": GraphQLField(
             args={"nested": GraphQLArgument(type_=nestedInput)},
-            resolve=lambda *args, **kwargs: 1,
-            type_=GraphQLInt,
+            resolve=lambda *args, **kwargs: json.dumps(kwargs["nested"]),
+            type_=GraphQLString,
         ),
     },
 )

tests/nested_input/test_nested_input.py

@@ -15,6 +15,20 @@ def client():
     return Client(schema=NestedInputSchema)
 
 
-def test_nested_input_with_new_get_arg_serializer(ds, client):
-    query = dsl_gql(ds.Query.foo.args(nested={"foo": 1}))
-    assert client.execute(query) == {"foo": 1}
+def test_nested_input(ds, client):
+    query = dsl_gql(ds.Query.echo.args(nested={"foo": 1}))
+    assert client.execute(query) == {"echo": '{"foo": 1}'}
+
+
+def test_nested_input_2(ds, client):
+    query = dsl_gql(ds.Query.echo.args(nested={"foo": 1, "child": {"foo": 2}}))
+    assert client.execute(query) == {"echo": '{"foo": 1, "child": {"foo": 2}}'}
+
+
+def test_nested_input_3(ds, client):
+    query = dsl_gql(
+        ds.Query.echo.args(nested={"foo": 1, "child": {"foo": 2, "child": {"foo": 3}}})
+    )
+    assert client.execute(query) == {
+        "echo": '{"foo": 1, "child": {"foo": 2, "child": {"foo": 3}}}'
+    }