Skip to content

Commit e16fa65

Browse files
committed
Merge remote-tracking branch 'origin/master' into reactive-streams-branch
# Conflicts: # build.gradle
2 parents 288be41 + 6ede2e6 commit e16fa65

19 files changed

+375
-396
lines changed

build.gradle

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,14 @@ dependencies {
7171
api 'org.reactivestreams:reactive-streams:' + reactiveStreamsVersion
7272

7373
testImplementation 'org.slf4j:slf4j-simple:' + slf4jVersion
74-
testImplementation 'junit:junit:4.12'
7574
testImplementation 'org.awaitility:awaitility:2.0.0'
75+
testImplementation "org.hamcrest:hamcrest:2.2"
7676
testImplementation 'io.projectreactor:reactor-core:3.6.6'
7777
testImplementation 'com.github.ben-manes.caffeine:caffeine:2.9.0'
78+
testImplementation platform('org.junit:junit-bom:5.10.2')
79+
testImplementation 'org.junit.jupiter:junit-jupiter-api'
80+
testImplementation 'org.junit.jupiter:junit-jupiter-params'
81+
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine'
7882
testImplementation 'io.projectreactor:reactor-core:3.6.6'
7983
}
8084

@@ -102,6 +106,7 @@ test {
102106
testLogging {
103107
exceptionFormat = 'full'
104108
}
109+
useJUnitPlatform()
105110
}
106111

107112
publishing {

src/test/java/org/dataloader/DataLoaderBatchLoaderEnvironmentTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.dataloader;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
import java.util.ArrayList;
66
import java.util.HashMap;
@@ -14,8 +14,8 @@
1414
import static java.util.Collections.singletonList;
1515
import static org.dataloader.DataLoaderFactory.newDataLoader;
1616
import static org.dataloader.DataLoaderFactory.newMappedDataLoader;
17+
import static org.hamcrest.MatcherAssert.assertThat;
1718
import static org.hamcrest.Matchers.equalTo;
18-
import static org.junit.Assert.assertThat;
1919

2020
/**
2121
* Tests related to context. DataLoaderTest is getting to big and needs refactoring

src/test/java/org/dataloader/DataLoaderCacheMapTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package org.dataloader;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
import java.util.ArrayList;
66
import java.util.Collection;
77
import java.util.List;
88
import java.util.concurrent.CompletableFuture;
99

1010
import static org.dataloader.DataLoaderFactory.newDataLoader;
11+
import static org.hamcrest.MatcherAssert.assertThat;
1112
import static org.hamcrest.Matchers.equalTo;
12-
import static org.junit.Assert.assertThat;
1313

1414
/**
1515
* Tests for cacheMap functionality..

src/test/java/org/dataloader/DataLoaderIfPresentTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package org.dataloader;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
import java.util.Optional;
66
import java.util.concurrent.CompletableFuture;
77
import java.util.concurrent.CompletionStage;
88

99
import static org.dataloader.DataLoaderFactory.newDataLoader;
10+
import static org.hamcrest.MatcherAssert.assertThat;
1011
import static org.hamcrest.Matchers.equalTo;
1112
import static org.hamcrest.Matchers.sameInstance;
12-
import static org.junit.Assert.assertThat;
1313

1414
/**
1515
* Tests for IfPresent and IfCompleted functionality.

src/test/java/org/dataloader/DataLoaderMapBatchLoaderTest.java

Lines changed: 0 additions & 184 deletions
This file was deleted.

src/test/java/org/dataloader/DataLoaderRegistryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
import org.dataloader.stats.SimpleStatisticsCollector;
44
import org.dataloader.stats.Statistics;
5-
import org.junit.Test;
5+
import org.junit.jupiter.api.Test;
66

77
import java.util.concurrent.CompletableFuture;
88

99
import static java.util.Arrays.asList;
1010
import static org.dataloader.DataLoaderFactory.newDataLoader;
11+
import static org.hamcrest.MatcherAssert.assertThat;
1112
import static org.hamcrest.Matchers.equalTo;
1213
import static org.hamcrest.Matchers.hasItems;
1314
import static org.hamcrest.Matchers.sameInstance;
14-
import static org.junit.Assert.assertThat;
1515

1616
public class DataLoaderRegistryTest {
1717
final BatchLoader<Object, Object> identityBatchLoader = CompletableFuture::completedFuture;

src/test/java/org/dataloader/DataLoaderStatsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import org.dataloader.stats.context.IncrementCacheHitCountStatisticsContext;
1010
import org.dataloader.stats.context.IncrementLoadCountStatisticsContext;
1111
import org.dataloader.stats.context.IncrementLoadErrorCountStatisticsContext;
12-
import org.junit.Test;
12+
import org.junit.jupiter.api.Test;
1313

1414
import java.util.ArrayList;
1515
import java.util.List;
@@ -19,9 +19,9 @@
1919
import static java.util.Collections.singletonList;
2020
import static java.util.concurrent.CompletableFuture.completedFuture;
2121
import static org.dataloader.DataLoaderFactory.newDataLoader;
22+
import static org.hamcrest.MatcherAssert.assertThat;
2223
import static org.hamcrest.Matchers.equalTo;
2324
import static org.hamcrest.Matchers.hasSize;
24-
import static org.junit.Assert.assertThat;
2525

2626
/**
2727
* Tests related to stats. DataLoaderTest is getting to big and needs refactoring

0 commit comments

Comments
 (0)