Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit 43a74bb

Browse files
committed
fix: memory leak due to ReactiveApolloSubscriptionSession not closing
A memory leak was possible because ReactiveApolloSubscriptionSession did not call close on the ReactiveWebSocketSubscriptionSession that it owned.
1 parent 13cd484 commit 43a74bb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

graphql-kickstart-spring-webflux/src/main/java/graphql/kickstart/spring/webflux/apollo/ReactiveApolloSubscriptionSession.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@ public boolean isOpen() {
2020
return session.isOpen();
2121
}
2222

23+
@Override
24+
public void close(String reason) {
25+
super.close(reason);
26+
session.close(reason);
27+
}
28+
2329
@Override
2430
public Map<String, Object> getUserProperties() {
2531
return session.getUserProperties();

0 commit comments

Comments
 (0)