Skip to content

Commit 5f3e9c0

Browse files
committed
Change the default value of iOS Resolver setting
Change the default value of "Link Framework statically" in iOS Resolver settings to TRUE since it is very likely that some pod frameworks includes pre-built static libraries, and can cause unexpected crash in runtime if the app is build with with multiple targets (Unity 2019.3+).
1 parent fc2ed91 commit 5f3e9c0

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

source/IOSResolver/src/IOSResolver.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1032,7 +1032,7 @@ public static bool PodfileAddUseFrameworks {
10321032
/// </summary>
10331033
public static bool PodfileStaticLinkFrameworks {
10341034
get { return settings.GetBool(PREFERENCE_PODFILE_STATIC_LINK_FRAMEWORKS,
1035-
defaultValue: false); }
1035+
defaultValue: true); }
10361036
set {
10371037
settings.SetBool(PREFERENCE_PODFILE_STATIC_LINK_FRAMEWORKS, value);
10381038
}

source/IOSResolver/src/IOSResolverSettingsDialog.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,8 @@ public void OnGUI() {
222222
settings.podfileStaticLinkFrameworks =
223223
EditorGUILayout.Toggle(settings.podfileStaticLinkFrameworks);
224224
GUILayout.EndHorizontal();
225+
GUILayout.Label("Link frameworks statically is recommended just in case any pod " +
226+
"framework includes static libraries.");
225227
}
226228

227229
if (IOSResolver.MultipleXcodeTargetsSupported) {

0 commit comments

Comments
 (0)