Skip to content

Commit 038bcc3

Browse files
danielduhhgcf-owl-bot[bot]ddelgrosso1
authored
chore: set gcs-sdk-team as CODEOWNERS (#2582)
* Set CODEOWNERS as gcs-sdk-team * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update repo metadata with new team * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix broken types causing compilation failures --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
1 parent b1f8b38 commit 038bcc3

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66

77

88
# Unless specified, the jsteam is the default owner for nodejs repositories.
9-
* @googleapis/cloud-storage-dpe @googleapis/jsteam
9+
* @googleapis/gcs-sdk-team @googleapis/jsteam

.repo-metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"distribution_name": "@google-cloud/storage",
1111
"api_id": "storage-api.googleapis.com",
1212
"requires_billing": true,
13-
"codeowner_team": "@googleapis/cloud-storage-dpe",
13+
"codeowner_team": "@googleapis/gcs-sdk-team",
1414
"api_shortname": "storage",
1515
"library_type": "GAPIC_MANUAL"
1616
}

test/nodejs-common/util.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ describe('common/util', () => {
105105
let util: Util & {[index: string]: Function};
106106

107107
// eslint-disable-next-line @typescript-eslint/no-explicit-any
108-
function stub(method: keyof Util, meth: (...args: any[]) => void) {
108+
function stub(method: keyof Util, meth: (...args: any[]) => any) {
109109
return sandbox.stub(util, method).callsFake(meth);
110110
}
111111

test/signer.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -189,10 +189,9 @@ describe('signer', () => {
189189
const expiresNumber = accessibleAtNumber + 86400000; //2020-02-18T16:00:00-08:00
190190

191191
it('should set correct settings if accessibleAt provided', async () => {
192-
const authClientSign: sinon.SinonStub<
193-
[string],
194-
Promise<string>
195-
> = sandbox.stub(authClient, 'sign').resolves('signature');
192+
const authClientSign = sandbox
193+
.stub(authClient, 'sign')
194+
.resolves('signature');
196195
const accessibleAt = new Date(accessibleAtNumber);
197196
await signer.getSignedUrl({
198197
version: 'v4',
@@ -461,10 +460,7 @@ describe('signer', () => {
461460
});
462461

463462
describe('blobToSign', () => {
464-
let authClientSign: sinon.SinonStub<
465-
[blobToSign: string] & [data: string, endpoint?: string | undefined],
466-
Promise<string>
467-
>;
463+
let authClientSign: sinon.SinonStub;
468464
beforeEach(() => {
469465
authClientSign = sandbox
470466
.stub<GoogleAuth | AuthClient, 'sign'>(authClient, 'sign')

0 commit comments

Comments
 (0)