From f8c464921a26824534563c20d92830d1a6d56f03 Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Wed, 6 Nov 2024 11:11:03 +0200 Subject: [PATCH 1/3] docs: use secure links in .gitignore --- docs/.gitignore | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/.gitignore b/docs/.gitignore index 2433561c61cd..f14a70ffc3a5 100644 --- a/docs/.gitignore +++ b/docs/.gitignore @@ -20,7 +20,7 @@ coverage # nyc test coverage .nyc_output -# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) +# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files) .grunt # Bower dependency directory (https://bower.io/) @@ -29,7 +29,7 @@ bower_components # node-waf configuration .lock-wscript -# Compiled binary addons (http://nodejs.org/api/addons.html) +# Compiled binary addons (https://nodejs.org/api/addons.html) build/Release # Dependency directories From 6386818d98bd59ec60fc7df67db53f60ba2b8e45 Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Wed, 6 Nov 2024 11:05:15 +0200 Subject: [PATCH 2/3] dev: improve testdata example code for mnd --- pkg/golinters/mnd/testdata/mnd.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/golinters/mnd/testdata/mnd.go b/pkg/golinters/mnd/testdata/mnd.go index 33d8bef04db8..b2725904e683 100644 --- a/pkg/golinters/mnd/testdata/mnd.go +++ b/pkg/golinters/mnd/testdata/mnd.go @@ -12,10 +12,11 @@ func UseMagicNumber() { Timeout: 2 * time.Second, // want "Magic number: 2, in detected" } - res, err := c.Get("http://www.google.com") + res, err := c.Get("https://www.google.com") if err != nil { log.Fatal(err) } + defer res.Body.Close() if res.StatusCode != 200 { // want "Magic number: 200, in detected" log.Println("Something went wrong") } @@ -26,10 +27,11 @@ func UseNoMagicNumber() { Timeout: time.Second, } - res, err := c.Get("http://www.google.com") + res, err := c.Get("https://www.google.com") if err != nil { log.Fatal(err) } + defer res.Body.Close() if res.StatusCode != http.StatusOK { log.Println("Something went wrong") } From f9b13d1588fa5d6cb39606d02e5c9ca4fa77c33f Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Wed, 6 Nov 2024 11:16:48 +0100 Subject: [PATCH 3/3] review --- pkg/golinters/mnd/testdata/mnd.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/golinters/mnd/testdata/mnd.go b/pkg/golinters/mnd/testdata/mnd.go index b2725904e683..1c44fc49e1d7 100644 --- a/pkg/golinters/mnd/testdata/mnd.go +++ b/pkg/golinters/mnd/testdata/mnd.go @@ -31,7 +31,7 @@ func UseNoMagicNumber() { if err != nil { log.Fatal(err) } - defer res.Body.Close() + if res.StatusCode != http.StatusOK { log.Println("Something went wrong") }