From 72d7b3834b567f9eda9897ee9b3a485553699ffb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 17 Oct 2024 12:02:15 +0000 Subject: [PATCH 1/2] build(deps): bump github.com/kisielk/errcheck from 1.7.0 to 1.8.0 Bumps [github.com/kisielk/errcheck](https://github.com/kisielk/errcheck) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/kisielk/errcheck/releases) - [Commits](https://github.com/kisielk/errcheck/compare/v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/kisielk/errcheck dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 3c9462678bde..a1187ca2acef 100644 --- a/go.mod +++ b/go.mod @@ -60,7 +60,7 @@ require ( github.com/jjti/go-spancheck v0.6.2 github.com/julz/importas v0.1.0 github.com/karamaru-alpha/copyloopvar v1.1.0 - github.com/kisielk/errcheck v1.7.0 + github.com/kisielk/errcheck v1.8.0 github.com/kkHAIKE/contextcheck v1.1.5 github.com/kulti/thelper v0.6.3 github.com/kunwardeep/paralleltest v1.0.10 diff --git a/go.sum b/go.sum index 7694bf01431b..9776674403fe 100644 --- a/go.sum +++ b/go.sum @@ -318,8 +318,8 @@ github.com/julz/importas v0.1.0 h1:F78HnrsjY3cR7j0etXy5+TU1Zuy7Xt08X/1aJnH5xXY= github.com/julz/importas v0.1.0/go.mod h1:oSFU2R4XK/P7kNBrnL/FEQlDGN1/6WoxXEjSSXO0DV0= github.com/karamaru-alpha/copyloopvar v1.1.0 h1:x7gNyKcC2vRBO1H2Mks5u1VxQtYvFiym7fCjIP8RPos= github.com/karamaru-alpha/copyloopvar v1.1.0/go.mod h1:u7CIfztblY0jZLOQZgH3oYsJzpC2A7S6u/lfgSXHy0k= -github.com/kisielk/errcheck v1.7.0 h1:+SbscKmWJ5mOK/bO1zS60F5I9WwZDWOfRsC4RwfwRV0= -github.com/kisielk/errcheck v1.7.0/go.mod h1:1kLL+jV4e+CFfueBmI1dSK2ADDyQnlrnrY/FqKluHJQ= +github.com/kisielk/errcheck v1.8.0 h1:ZX/URYa7ilESY19ik/vBmCn6zdGQLxACwjAcWbHlYlg= +github.com/kisielk/errcheck v1.8.0/go.mod h1:1kLL+jV4e+CFfueBmI1dSK2ADDyQnlrnrY/FqKluHJQ= github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck= github.com/kkHAIKE/contextcheck v1.1.5 h1:CdnJh63tcDe53vG+RebdpdXJTc9atMgGqdx8LXxiilg= github.com/kkHAIKE/contextcheck v1.1.5/go.mod h1:O930cpht4xb1YQpK+1+AgoM3mFsvxr7uyFptcnWTYUA= From ff101f83719b6b738ce7cf7f01d3a8bb07486178 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Thu, 17 Oct 2024 14:16:23 +0200 Subject: [PATCH 2/2] chore: update implementation --- pkg/golinters/errcheck/testdata/errcheck_type_assertions.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/golinters/errcheck/testdata/errcheck_type_assertions.go b/pkg/golinters/errcheck/testdata/errcheck_type_assertions.go index 983c5c3f0e2e..94025db0ee37 100644 --- a/pkg/golinters/errcheck/testdata/errcheck_type_assertions.go +++ b/pkg/golinters/errcheck/testdata/errcheck_type_assertions.go @@ -1,8 +1,8 @@ //golangcitest:args -Eerrcheck //golangcitest:config_path testdata/errcheck_type_assertions.yml -//golangcitest:expected_exitcode 0 +//golangcitest:expected_exitcode 1 package testdata func ErrorTypeAssertion(filter map[string]interface{}) bool { - return filter["messages_sent.messageid"].(map[string]interface{})["$ne"] != nil + return filter["messages_sent.messageid"].(map[string]interface{})["$ne"] != nil // want "Error return value is not checked" }