chore: move show-stats deprecation warning

ldez · ldez · commit f57a0887d1bd · 2024-03-15T01:18:18.000+01:00
diff --git a/pkg/commands/run.go b/pkg/commands/run.go
@@ -425,11 +425,7 @@ func (c *runCommand) printDeprecatedLinterMessages(enabledLinters map[string]*li
 }
 
 func (c *runCommand) printStats(issues []result.Issue) {
-	if c.cfg.Run.ShowStats {
-		c.log.Warnf("The configuration option `run.show-stats` is deprecated, please use `output.show-stats`")
-	}
-
-	if !c.cfg.Run.ShowStats && !c.cfg.Output.ShowStats {
+	if !c.cfg.Output.ShowStats {
 		return
 	}
 
diff --git a/pkg/config/loader.go b/pkg/config/loader.go
@@ -132,6 +132,12 @@ func (l *Loader) handleDeprecation() {
 		l.log.Warnf("The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`.")
 	}
 	l.cfg.Issues.UseDefaultExcludeDirs = l.cfg.Run.UseDefaultSkipDirs && l.cfg.Issues.UseDefaultExcludeDirs
+
+	// The 2 options are false by default.
+	if l.cfg.Run.ShowStats {
+		l.log.Warnf("The configuration option `run.show-stats` is deprecated, please use `output.show-stats`")
+	}
+	l.cfg.Output.ShowStats = l.cfg.Run.ShowStats || l.cfg.Output.ShowStats
 }
 
 func (l *Loader) setConfigFile() error {

Original file line number	Diff line number	Diff line change
`@@ -425,11 +425,7 @@ func (c runCommand) printDeprecatedLinterMessages(enabledLinters map[string]li`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	`func (c *runCommand) printStats(issues []result.Issue) {`
`428`		`- if c.cfg.Run.ShowStats {`
`429`		- c.log.Warnf("The configuration option `run.show-stats` is deprecated, please use `output.show-stats`")
`430`		`- }`
`431`		`-`
`432`		`- if !c.cfg.Run.ShowStats && !c.cfg.Output.ShowStats {`
	`428`	`+ if !c.cfg.Output.ShowStats {`
`433`	`429`	`return`
`434`	`430`	`}`
`435`	`431`
Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,12 @@ func (l *Loader) handleDeprecation() {`
`132`	`132`	l.log.Warnf("The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`.")
`133`	`133`	`}`
`134`	`134`	`l.cfg.Issues.UseDefaultExcludeDirs = l.cfg.Run.UseDefaultSkipDirs && l.cfg.Issues.UseDefaultExcludeDirs`
	`135`	`+`
	`136`	`+ // The 2 options are false by default.`
	`137`	`+ if l.cfg.Run.ShowStats {`
	`138`	+ l.log.Warnf("The configuration option `run.show-stats` is deprecated, please use `output.show-stats`")
	`139`	`+ }`
	`140`	`+ l.cfg.Output.ShowStats = l.cfg.Run.ShowStats \|\| l.cfg.Output.ShowStats`
`135`	`141`	`}`
`136`	`142`
`137`	`143`	`func (l *Loader) setConfigFile() error {`