Skip to content

Commit ee8be36

Browse files
committed
review: update implementation
1 parent 36587db commit ee8be36

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

.golangci.reference.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,6 +1607,11 @@ linters-settings:
16071607
# Regexp pattern to skip files.
16081608
# Default: "(export|internal)_test\\.go"
16091609
skip-regexp: (export|internal)_test\.go
1610+
# List of packages that don't end with _test that tests are allowed to be in.
1611+
# Default: "main"
1612+
allow-packages:
1613+
- example
1614+
- main
16101615

16111616
thelper:
16121617
test:

pkg/config/linters_settings.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ var defaultLintersSettings = LintersSettings{
8888
Qualified: false,
8989
},
9090
Testpackage: TestpackageSettings{
91-
SkipRegexp: `(export|internal)_test\.go`,
91+
SkipRegexp: `(export|internal)_test\.go`,
92+
AllowPackages: []string{"main"},
9293
},
9394
Unparam: UnparamSettings{
9495
Algo: "cha",
@@ -558,7 +559,8 @@ type TagliatelleSettings struct {
558559
}
559560

560561
type TestpackageSettings struct {
561-
SkipRegexp string `mapstructure:"skip-regexp"`
562+
SkipRegexp string `mapstructure:"skip-regexp"`
563+
AllowPackages []string `mapstructure:"allow-packages"`
562564
}
563565

564566
type ThelperSettings struct {

pkg/golinters/testpackage.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package golinters
22

33
import (
4+
"strings"
5+
46
"github.com/maratori/testpackage/pkg/testpackage"
57
"golang.org/x/tools/go/analysis"
68

@@ -15,7 +17,8 @@ func NewTestpackage(cfg *config.TestpackageSettings) *goanalysis.Linter {
1517
if cfg != nil {
1618
settings = map[string]map[string]interface{}{
1719
a.Name: {
18-
testpackage.SkipRegexpFlagName: cfg.SkipRegexp,
20+
testpackage.SkipRegexpFlagName: cfg.SkipRegexp,
21+
testpackage.AllowPackagesFlagName: strings.Join(cfg.AllowPackages, ","),
1922
},
2023
}
2124
}

0 commit comments

Comments
 (0)