dev: enable revive linter

Fixes revive issues:
- useless-break: useless break in case clause
- if-return: redundant if ...; err != nil check, just return error instead.

Author: alexandear

.golangci.yml

@@ -63,6 +63,99 @@ linters-settings:
     allow-unused: false # report any unused nolint directives
     require-explanation: false # don't require an explanation for nolint directives
     require-specific: false # don't require nolint directives to be specific about which linter is being skipped
+  revive:
+    rules:
+      - name: atomic
+        disabled: false
+      - name: blank-imports
+        disabled: false
+      - name: bool-literal-in-expr
+        disabled: false
+      - name: call-to-gc
+        disabled: false
+      - name: confusing-results
+        disabled: false
+      - name: constant-logical-expr
+        disabled: false
+      - name: context-as-argument
+        disabled: false
+      - name: context-keys-type
+        disabled: false
+      - name: datarace
+        disabled: false
+      - name: defer
+        disabled: false
+      - name: dot-imports
+        disabled: false
+      - name: duplicated-imports
+        disabled: false
+      - name: early-return
+        disabled: false
+      - name: empty-block
+        disabled: false
+      - name: empty-lines
+        disabled: false
+      - name: error-naming
+        disabled: false
+      - name: error-return
+        disabled: false
+      - name: error-strings
+        disabled: false
+      - name: errorf
+        disabled: false
+      - name: exported
+        disabled: false
+        arguments:
+          - "checkPrivateReceivers"
+          - "sayRepetitiveInsteadOfStutters"
+      - name: get-return
+        disabled: false
+      - name: identical-branches
+        disabled: false
+      - name: if-return
+        disabled: false
+      - name: increment-decrement
+        disabled: false
+      - name: indent-error-flow
+        disabled: false
+      - name: modifies-parameter
+        disabled: false
+      - name: modifies-value-receiver
+        disabled: false
+      - name: optimize-operands-order
+        disabled: false
+      - name: package-comments
+        disabled: false
+      - name: range
+        disabled: false
+      - name: range-val-in-closure
+        disabled: false
+      - name: range-val-address
+        disabled: false
+      - name: receiver-naming
+        disabled: false
+      - name: redefines-builtin-id
+        disabled: false
+      - name: string-of-int
+        disabled: false
+      - name: superfluous-else
+        disabled: false
+      - name: time-equal
+        disabled: false
+      - name: time-naming
+        disabled: false
+      - name: var-naming
+        disabled: false
+      - name: var-declaration
+        disabled: false
+      - name: unconditional-recursion
+        disabled: false
+      - name: unreachable-code
+        disabled: false
+      - name: useless-break
+        disabled: false
+      - name: waitgroup-by-value
+        disabled: false
 
 linters:
   disable-all: true
@@ -91,6 +184,7 @@ linters:
     - nakedret
     - noctx
     - nolintlint
+    - revive
     - staticcheck
     - stylecheck
     - typecheck
@@ -112,7 +206,6 @@ linters:
   # - nestif
   # - prealloc
   # - testpackage
-  # - revive
   # - wsl
 
 issues:

pkg/golinters/lll.go

@@ -121,6 +121,7 @@ func getLLLIssuesForFile(filename string, maxLineLen int, tabSpaces string) ([]r
 	}
 
 	if err := scanner.Err(); err != nil {
+		//nolint:revive // early-return
 		if err == bufio.ErrTooLong && maxLineLen < bufio.MaxScanTokenSize {
 			// scanner.Scan() might fail if the line is longer than bufio.MaxScanTokenSize
 			// In the case where the specified maxLineLen is smaller than bufio.MaxScanTokenSize

pkg/lint/lintersdb/enabled_set.go

@@ -35,12 +35,9 @@ func (es EnabledSet) build(lcfg *config.Linters, enabledByDefaultLinters []*lint
 	es.debugf("Linters config: %#v", lcfg)
 	resultLintersSet := map[string]*linter.Config{}
 	switch {
-	case len(lcfg.Presets) != 0:
-		break // imply --disable-all
+	case lcfg.DisableAll, len(lcfg.Presets) != 0:
 	case lcfg.EnableAll:
 		resultLintersSet = linterConfigsToMap(es.m.GetAllSupportedLinterConfigs())
-	case lcfg.DisableAll:
-		break
 	default:
 		resultLintersSet = linterConfigsToMap(enabledByDefaultLinters)
 	}

pkg/printers/junitxml.go

@@ -82,8 +82,5 @@ func (p JunitXML) Print(ctx context.Context, issues []result.Issue) error {
 
 	enc := xml.NewEncoder(p.w)
 	enc.Indent("", "  ")
-	if err := enc.Encode(res); err != nil {
-		return err
-	}
-	return nil
+	return enc.Encode(res)
 }