Fix go1.13

Author: ashanbrown

test/fix_test.go

@@ -26,10 +26,12 @@ func TestFix(t *testing.T) {
 
 	if os.Getenv("GL_KEEP_TEMP_FILES") == "1" {
 		t.Logf("Temp dir for fix test: %s", tmpDir)
-	} else {
-		t.Cleanup(func() {
+	} else if tCleanupExists {
+		registerCleanup(t, func() {
 			os.RemoveAll(tmpDir)
 		})
+	} else {
+		os.RemoveAll(tmpDir)
 	}
 
 	fixDir := filepath.Join(testdataDir, "fix")
@@ -40,7 +42,10 @@ func TestFix(t *testing.T) {
 	for _, input := range inputs {
 		input := input
 		t.Run(filepath.Base(input), func(t *testing.T) {
-			t.Parallel()
+			// if t.Cleanup does not exist, don't run these tests concurrently because we need to use defer for clean up
+			if tCleanupExists {
+				t.Parallel()
+			}
 			args := []string{
 				"--disable-all", "--print-issued-lines=false", "--print-linter-name=false", "--out-format=line-number",
 				"--allow-parallel-runners", "--fix",

test/fix_test_go1_13.go

@@ -0,0 +1,10 @@
+// +build !go1.14
+
+package test
+
+import "testing"
+
+const tCleanupExists = false
+
+// do nothing for go.1.13
+func registerCleanup(t *testing.T, f func()) {}

test/register_cleanup.go

@@ -0,0 +1,12 @@
+// +build go1.14
+
+package test
+
+import "testing"
+
+const tCleanupExists = true
+
+// registerCleanup exists because t.Cleanup doesn't exist prior to go1.14
+func registerCleanup(t *testing.T, f func()) {
+	t.Cleanup(f)
+}