review

ldez · alexandear · web-flow · commit d4915921ebea · 2024-03-18T14:50:28.000+01:00
Co-authored-by: Oleksandr Redko &lt;oleksandr.red+github@gmail.com&gt;
diff --git a/pkg/golinters/govet.go b/pkg/golinters/govet.go
@@ -189,10 +189,9 @@ func isAnalyzerEnabled(name string, cfg *config.GovetSettings, defaultAnalyzers
 		return false
 	}
 
-	// TODO(ldez) remove httpresponse because of a panic.
-	// https://github.com/golangci/golangci-lint/issues/4482
-	// https://github.com/golang/go/issues/66259
+	// TODO(ldez) enable httpresponse once https://github.com/golang/go/issues/66259 is fixed.
 	if name == httpresponse.Analyzer.Name {
+		govetDebugf("httpresponse is disabled due to panic. See https://github.com/golangci/golangci-lint/issues/4482")
 		return false
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -189,10 +189,9 @@ func isAnalyzerEnabled(name string, cfg *config.GovetSettings, defaultAnalyzers`
`189`	`189`	`return false`
`190`	`190`	`}`
`191`	`191`
`192`		`- // TODO(ldez) remove httpresponse because of a panic.`
`193`		`- // https://github.com/golangci/golangci-lint/issues/4482`
`194`		`- // https://github.com/golang/go/issues/66259`
	`192`	`+ // TODO(ldez) enable httpresponse once https://github.com/golang/go/issues/66259 is fixed.`
`195`	`193`	`if name == httpresponse.Analyzer.Name {`
	`194`	`+ govetDebugf("httpresponse is disabled due to panic. See https://github.com/golangci/golangci-lint/issues/4482")`
`196`	`195`	`return false`
`197`	`196`	`}`
`198`	`197`