|
1 | 1 | //golangcitest:args -Eunconvert |
2 | 2 | package testdata |
3 | 3 |
|
4 | | -import "log" |
| 4 | +import "io" |
5 | 5 |
|
6 | | -func Unconvert() { |
7 | | - a := 1 |
8 | | - b := int(a) // want "unnecessary conversion" |
9 | | - log.Print(b) |
| 6 | +// Various explicit conversions of untyped constants |
| 7 | +// that cannot be removed. |
| 8 | +func _() { |
| 9 | + const ( |
| 10 | + _ = byte(0) |
| 11 | + _ = int((real)(0i)) |
| 12 | + _ = complex64(complex(1, 2)) |
| 13 | + _ = (bool)(true || false) |
| 14 | + |
| 15 | + PtrSize = 4 << (^uintptr(0) >> 63) |
| 16 | + c0 = uintptr(PtrSize) |
| 17 | + c1 = uintptr((8-PtrSize)/4*2860486313 + (PtrSize-4)/4*33054211828000289) |
| 18 | + ) |
| 19 | + |
| 20 | + i := int64(0) |
| 21 | + _ = i |
| 22 | +} |
| 23 | + |
| 24 | +// Make sure we distinguish function calls from |
| 25 | +// conversion to function type. |
| 26 | +func _() { |
| 27 | + type F func(F) int |
| 28 | + var f F |
| 29 | + |
| 30 | + _ = F(F(nil)) // want "unnecessary conversion" |
| 31 | + _ = f(F(nil)) |
| 32 | +} |
| 33 | + |
| 34 | +// Make sure we don't remove explicit conversions that |
| 35 | +// prevent fusing floating-point operation. |
| 36 | +func _() { |
| 37 | + var f1, f2, f3, ftmp float64 |
| 38 | + _ = f1 + float64(f2*f3) |
| 39 | + ftmp = float64(f2 * f3) |
| 40 | + _ = f1 + ftmp |
| 41 | + ftmp = f2 * f3 |
| 42 | + _ = f1 + float64(ftmp) |
| 43 | + |
| 44 | + var c1, c2, c3, ctmp complex128 |
| 45 | + _ = c1 + complex128(c2*c3) |
| 46 | + ctmp = complex128(c2 * c3) |
| 47 | + _ = c1 + ctmp |
| 48 | + ctmp = c2 * c3 |
| 49 | + _ = c1 + complex128(ctmp) |
| 50 | +} |
| 51 | + |
| 52 | +// Basic contains conversion errors for builtin data types |
| 53 | +func Basic() { |
| 54 | + var vbool bool |
| 55 | + var vbyte byte |
| 56 | + var vcomplex128 complex128 |
| 57 | + var vcomplex64 complex64 |
| 58 | + var verror error |
| 59 | + var vfloat32 float32 |
| 60 | + var vfloat64 float64 |
| 61 | + var vint int |
| 62 | + var vint16 int16 |
| 63 | + var vint32 int32 |
| 64 | + var vint64 int64 |
| 65 | + var vint8 int8 |
| 66 | + var vrune rune |
| 67 | + var vstring string |
| 68 | + var vuint uint |
| 69 | + var vuint16 uint16 |
| 70 | + var vuint32 uint32 |
| 71 | + var vuint64 uint64 |
| 72 | + var vuint8 uint8 |
| 73 | + var vuintptr uintptr |
| 74 | + |
| 75 | + _ = bool(vbool) // want "unnecessary conversion" |
| 76 | + _ = byte(vbyte) // want "unnecessary conversion" |
| 77 | + _ = error(verror) // want "unnecessary conversion" |
| 78 | + _ = int(vint) // want "unnecessary conversion" |
| 79 | + _ = int16(vint16) // want "unnecessary conversion" |
| 80 | + _ = int32(vint32) // want "unnecessary conversion" |
| 81 | + _ = int64(vint64) // want "unnecessary conversion" |
| 82 | + _ = int8(vint8) // want "unnecessary conversion" |
| 83 | + _ = rune(vrune) // want "unnecessary conversion" |
| 84 | + _ = string(vstring) // want "unnecessary conversion" |
| 85 | + _ = uint(vuint) // want "unnecessary conversion" |
| 86 | + _ = uint16(vuint16) // want "unnecessary conversion" |
| 87 | + _ = uint32(vuint32) // want "unnecessary conversion" |
| 88 | + _ = uint64(vuint64) // want "unnecessary conversion" |
| 89 | + _ = uint8(vuint8) // want "unnecessary conversion" |
| 90 | + _ = uintptr(vuintptr) // want "unnecessary conversion" |
| 91 | + |
| 92 | + _ = float32(vfloat32) |
| 93 | + _ = float64(vfloat64) |
| 94 | + _ = complex128(vcomplex128) |
| 95 | + _ = complex64(vcomplex64) |
| 96 | + |
| 97 | + // Pointers |
| 98 | + _ = (*bool)(&vbool) // want "unnecessary conversion" |
| 99 | + _ = (*byte)(&vbyte) // want "unnecessary conversion" |
| 100 | + _ = (*complex128)(&vcomplex128) // want "unnecessary conversion" |
| 101 | + _ = (*complex64)(&vcomplex64) // want "unnecessary conversion" |
| 102 | + _ = (*error)(&verror) // want "unnecessary conversion" |
| 103 | + _ = (*float32)(&vfloat32) // want "unnecessary conversion" |
| 104 | + _ = (*float64)(&vfloat64) // want "unnecessary conversion" |
| 105 | + _ = (*int)(&vint) // want "unnecessary conversion" |
| 106 | + _ = (*int16)(&vint16) // want "unnecessary conversion" |
| 107 | + _ = (*int32)(&vint32) // want "unnecessary conversion" |
| 108 | + _ = (*int64)(&vint64) // want "unnecessary conversion" |
| 109 | + _ = (*int8)(&vint8) // want "unnecessary conversion" |
| 110 | + _ = (*rune)(&vrune) // want "unnecessary conversion" |
| 111 | + _ = (*string)(&vstring) // want "unnecessary conversion" |
| 112 | + _ = (*uint)(&vuint) // want "unnecessary conversion" |
| 113 | + _ = (*uint16)(&vuint16) // want "unnecessary conversion" |
| 114 | + _ = (*uint32)(&vuint32) // want "unnecessary conversion" |
| 115 | + _ = (*uint64)(&vuint64) // want "unnecessary conversion" |
| 116 | + _ = (*uint8)(&vuint8) // want "unnecessary conversion" |
| 117 | + _ = (*uintptr)(&vuintptr) // want "unnecessary conversion" |
| 118 | +} |
| 119 | + |
| 120 | +// Counter is an int64 |
| 121 | +type Counter int64 |
| 122 | + |
| 123 | +// ID is a typed identifier |
| 124 | +type ID string |
| 125 | + |
| 126 | +// Metric is a struct |
| 127 | +type Metric struct { |
| 128 | + ID ID |
| 129 | + Counter Counter |
| 130 | +} |
| 131 | + |
| 132 | +// Custom contains conversion errors for builtin data types |
| 133 | +func Custom() { |
| 134 | + type Local struct{ id ID } |
| 135 | + |
| 136 | + var counter Counter |
| 137 | + var id ID |
| 138 | + var m Metric |
| 139 | + var local Local |
| 140 | + var x struct{ id ID } |
| 141 | + |
| 142 | + _ = Counter(counter) // want "unnecessary conversion" |
| 143 | + _ = ID(id) // want "unnecessary conversion" |
| 144 | + _ = Metric(m) // want "unnecessary conversion" |
| 145 | + _ = Local(local) // want "unnecessary conversion" |
| 146 | + _ = (struct{ id ID })(x) // want "unnecessary conversion" |
| 147 | + |
| 148 | + // Pointers |
| 149 | + _ = (*Counter)(&counter) // want "unnecessary conversion" |
| 150 | + _ = (*ID)(&id) // want "unnecessary conversion" |
| 151 | + _ = (*Metric)(&m) // want "unnecessary conversion" |
| 152 | + _ = (*Local)(&local) // want "unnecessary conversion" |
| 153 | + _ = (*struct{ id ID })(&x) // want "unnecessary conversion" |
| 154 | +} |
| 155 | + |
| 156 | +// Interfaces contains conversion errors for interfaces |
| 157 | +func Interfaces() { |
| 158 | + var writer io.Writer |
| 159 | + |
| 160 | + _ = (io.Writer)(writer) // want "unnecessary conversion" |
| 161 | + _ = (*io.Writer)(&writer) // want "unnecessary conversion" |
| 162 | +} |
| 163 | + |
| 164 | +// Constructor is a func type |
| 165 | +type Constructor func() ID |
| 166 | + |
| 167 | +// Funcs contains conversion errors for func types |
| 168 | +func Funcs() { |
| 169 | + type Local func(ID) |
| 170 | + type Recursive func(Recursive) |
| 171 | + |
| 172 | + var ctor Constructor |
| 173 | + var local Local |
| 174 | + var recursive Recursive |
| 175 | + |
| 176 | + _ = Constructor(ctor) // want "unnecessary conversion" |
| 177 | + _ = Local(local) // want "unnecessary conversion" |
| 178 | + _ = Recursive(recursive) // want "unnecessary conversion" |
| 179 | + |
| 180 | + _ = (*Constructor)(&ctor) // want "unnecessary conversion" |
| 181 | + _ = (*Local)(&local) // want "unnecessary conversion" |
| 182 | + _ = (*Recursive)(&recursive) // want "unnecessary conversion" |
10 | 183 | } |
0 commit comments