fix(nolintlint): remove empty line in unused directive replacement

Author: reugn

pkg/golinters/nolintlint/internal/nolintlint.go

@@ -259,6 +259,11 @@ func (l Linter) Run(fset *token.FileSet, nodes ...ast.Node) ([]Issue, error) {
 							NewString: "",
 						},
 					}
+					// if the directive starts from a new line, remove the line
+					if removeNolintCompletely.Inline.StartCol == 0 {
+						removeNolintCompletely.NeedOnlyDelete = true
+						removeNolintCompletely.Inline = nil
+					}
 
 					if len(linters) == 0 {
 						issue := UnusedCandidate{BaseIssue: base}

pkg/golinters/nolintlint/internal/nolintlint_test.go

@@ -188,6 +188,25 @@ func foo() {
 				},
 			},
 		},
+		{
+			desc:  "needs unused with one specific linter in a new line generates replacement",
+			needs: NeedsUnused,
+			contents: `
+package bar
+
+//nolint:somelinter
+func foo() {
+  bad()
+}`,
+			expected: []issueWithReplacement{
+				{
+					issue: "directive `//nolint:somelinter` is unused for linter \"somelinter\" at testing.go:4:1",
+					replacement: &result.Replacement{
+						NeedOnlyDelete: true,
+					},
+				},
+			},
+		},
 		{
 			desc:  "needs unused with multiple specific linters does not generate replacements",
 			needs: NeedsUnused,