Skip to content

Commit a701970

Browse files
committed
chore: remove the dummyLogger
1 parent aaef7fc commit a701970

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed

pkg/lint/lintersdb/manager_test.go

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -12,30 +12,12 @@ import (
1212
"github.com/golangci/golangci-lint/pkg/logutils"
1313
)
1414

15-
type dummyLogger struct{}
16-
17-
func (d dummyLogger) Fatalf(_ string, _ ...any) {}
18-
19-
func (d dummyLogger) Panicf(_ string, _ ...any) {}
20-
21-
func (d dummyLogger) Errorf(_ string, _ ...any) {}
22-
23-
func (d dummyLogger) Warnf(_ string, _ ...any) {}
24-
25-
func (d dummyLogger) Infof(_ string, _ ...any) {}
26-
27-
func (d dummyLogger) Child(_ string) logutils.Log {
28-
return &d
29-
}
30-
31-
func (d dummyLogger) SetLevel(_ logutils.LogLevel) {}
32-
3315
func TestManager_GetEnabledLintersMap(t *testing.T) {
3416
cfg := config.NewDefault()
3517
cfg.Linters.DisableAll = true
3618
cfg.Linters.Enable = []string{"gofmt"}
3719

38-
m, err := NewManager(&dummyLogger{}, cfg, NewLinterBuilder())
20+
m, err := NewManager(logutils.NewStderrLog("skip"), cfg, NewLinterBuilder())
3921
require.NoError(t, err)
4022

4123
lintersMap, err := m.GetEnabledLintersMap()
@@ -57,7 +39,7 @@ func TestManager_GetOptimizedLinters(t *testing.T) {
5739
cfg.Linters.DisableAll = true
5840
cfg.Linters.Enable = []string{"gofmt"}
5941

60-
m, err := NewManager(&dummyLogger{}, cfg, NewLinterBuilder())
42+
m, err := NewManager(logutils.NewStderrLog("skip"), cfg, NewLinterBuilder())
6143
require.NoError(t, err)
6244

6345
optimizedLinters, err := m.GetOptimizedLinters()
@@ -168,7 +150,7 @@ func TestManager_build(t *testing.T) {
168150
for _, c := range cases {
169151
c := c
170152
t.Run(c.name, func(t *testing.T) {
171-
m, err := NewManager(&dummyLogger{}, &config.Config{Linters: c.cfg}, NewLinterBuilder())
153+
m, err := NewManager(logutils.NewStderrLog("skip"), &config.Config{Linters: c.cfg}, NewLinterBuilder())
172154
require.NoError(t, err)
173155

174156
var defaultLinters []*linter.Config

0 commit comments

Comments
 (0)