fix rowserrcheck reports false positive #943

Author: jingyugao

go.mod

@@ -14,6 +14,7 @@ require (
 	github.com/esimonov/ifshort v1.0.0
 	github.com/fatih/color v1.10.0
 	github.com/go-critic/go-critic v0.5.3
+	github.com/go-sql-driver/mysql v1.4.0
 	github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
 	github.com/gofrs/flock v0.8.0
 	github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
@@ -30,8 +31,9 @@ require (
 	github.com/golangci/revgrep v0.0.0-20180526074752-d9c87f5ffaf0
 	github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4
 	github.com/jgautheron/goconst v0.0.0-20201117150253-ccae5bf973f3
-	github.com/jingyugao/rowserrcheck v0.0.0-20191204022205-72ab7603b68a
+	github.com/jingyugao/rowserrcheck v0.0.0-20210130005344-c6a0c12dd98d
 	github.com/jirfag/go-printf-func-name v0.0.0-20191110105641-45db9963cdd3
+	github.com/jmoiron/sqlx v1.2.0
 	github.com/kulti/thelper v0.2.1
 	github.com/kunwardeep/paralleltest v1.0.2
 	github.com/kyoh86/exportloopref v0.1.8
@@ -69,6 +71,7 @@ require (
 	github.com/ultraware/whitespace v0.0.4
 	github.com/uudashr/gocognit v1.0.1
 	github.com/valyala/quicktemplate v1.6.3
+	golang.org/x/mod v0.4.0
 	golang.org/x/sys v0.0.0-20201009025420-dfb3f7c4e634 // indirect
 	golang.org/x/text v0.3.4 // indirect
 	golang.org/x/tools v0.0.0-20210105210202-9ed45478a130

go.sum

@@ -3,6 +3,8 @@ package testdata
 
 import (
 	"database/sql"
+	"fmt"
+	"math/rand"
 )
 
 func RowsErrNotChecked(db *sql.DB) {
@@ -11,3 +13,53 @@ func RowsErrNotChecked(db *sql.DB) {
 
 	}
 }
+
+func issue943_1() {
+	db, err := sql.Open("postgres", "postgres://localhost:5432/postgres")
+	if err != nil {
+		panic(err)
+	}
+	defer db.Close()
+
+	var rows *sql.Rows
+	if rand.Float64() < 0.5 {
+		rows, err = db.Query("select 1")
+	} else {
+		rows, err = db.Query("select 2")
+	}
+	if err != nil {
+		panic(err)
+	}
+	defer rows.Close()
+	for rows.Next() {
+		fmt.Println("new rows")
+	}
+	if err := rows.Err(); err != nil {
+		panic(err)
+	}
+}
+
+func issue943_1() {
+	db, err := sql.Open("postgres", "postgres://localhost:5432/postgres")
+	if err != nil {
+		panic(err)
+	}
+	defer db.Close()
+
+	var rows *sql.Rows
+	if rand.Float64() < 0.5 {
+		rows, err = db.Query("select 1") // ERROR "rows.Err must be checked"
+	} else {
+		rows, err = db.Query("select 2") // ERROR "rows.Err must be checked"
+	}
+	if err != nil {
+		panic(err)
+	}
+	defer rows.Close()
+	for rows.Next() {
+		fmt.Println("new rows")
+	}
+	if err := rows.Err(); err != nil {
+		panic(err)
+	}
+}