review

Author: ldez

go.mod

@@ -13,6 +13,7 @@ require (
 	github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
 	github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0
 	github.com/OpenPeeDeeP/depguard/v2 v2.1.0
+	github.com/alecthomas/go-check-sumtype v0.1.3
 	github.com/alexkohler/nakedret/v2 v2.0.1
 	github.com/alexkohler/prealloc v1.0.0
 	github.com/alingse/asasalint v0.0.11
@@ -127,7 +128,6 @@ require (
 
 require (
 	github.com/Masterminds/semver v1.5.0 // indirect
-	github.com/alecthomas/go-check-sumtype v0.1.3
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/cespare/xxhash/v2 v2.1.2 // indirect
 	github.com/chavacava/garif v0.0.0-20230227094218-b8c73b2037b8 // indirect

pkg/golinters/gochecksumtype.go

@@ -27,15 +27,19 @@ func NewGoCheckSumType() *goanalysis.Linter {
 			if err != nil {
 				return nil, err
 			}
+
 			if len(issues) == 0 {
 				return nil, nil
 			}
+
 			mu.Lock()
 			resIssues = append(resIssues, issues...)
 			mu.Unlock()
+
 			return nil, nil
 		},
 	}
+
 	return goanalysis.NewLinter(
 		goCheckSumTypeName,
 		`Run exhaustiveness checks on Go "sum types"`,
@@ -47,13 +51,15 @@ func NewGoCheckSumType() *goanalysis.Linter {
 }
 
 func runGoCheckSumType(pass *analysis.Pass) ([]goanalysis.Issue, error) {
-	resIssues := []goanalysis.Issue{}
+	var resIssues []goanalysis.Issue
+
 	pkg := &packages.Package{
 		Fset:      pass.Fset,
 		Syntax:    pass.Files,
 		Types:     pass.Pkg,
 		TypesInfo: pass.TypesInfo,
 	}
+
 	var unknownError error
 	errors := gochecksumtype.Run([]*packages.Package{pkg})
 	for _, err := range errors {
@@ -62,12 +68,13 @@ func runGoCheckSumType(pass *analysis.Pass) ([]goanalysis.Issue, error) {
 			unknownError = err
 			continue
 		}
-		prefix := err.Pos().String() + ": "
+
 		resIssues = append(resIssues, goanalysis.NewIssue(&result.Issue{
 			FromLinter: goCheckSumTypeName,
-			Text:       strings.TrimPrefix(err.Error(), prefix),
+			Text:       strings.TrimPrefix(err.Error(), err.Pos().String()+": "),
 			Pos:        err.Pos(),
 		}, pass))
 	}
+
 	return resIssues, unknownError
 }

pkg/golinters/unparam.go

@@ -37,6 +37,7 @@ func NewUnparam(settings *config.UnparamSettings) *goanalysis.Linter {
 			mu.Lock()
 			resIssues = append(resIssues, issues...)
 			mu.Unlock()
+
 			return nil, nil
 		},
 	}

pkg/lint/lintersdb/manager.go

@@ -471,8 +471,9 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle),
 
 		linter.NewConfig(golinters.NewGoCheckSumType()).
-			WithSince("v1.51.2").
+			WithSince("v1.53.0").
 			WithPresets(linter.PresetBugs).
+			WithLoadForGoAnalysis().
 			WithURL("https://github.com/alecthomas/go-check-sumtype"),
 
 		linter.NewConfig(golinters.NewGocognit(gocognitCfg)).