Merge branch 'master' into feat/testifylint

Author: Antonboom

.github/workflows/tag.yml

@@ -21,7 +21,7 @@ jobs:
         run: git fetch --prune --unshallow
 
       - name: Create release
-        uses: goreleaser/goreleaser-action@v4
+        uses: goreleaser/goreleaser-action@v5
         with:
           version: latest
           args: release --clean

.pre-commit-hooks.yaml

@@ -1,8 +1,16 @@
 - id: golangci-lint
   name: golangci-lint
-  description: Fast linters runner for Go.
+  description: Fast linters runner for Go. Note that only modified files are linted, so linters like 'unused' that need to scan all files won't work as expected.
   entry: golangci-lint run --new-from-rev HEAD --fix
   types: [go]
   language: golang
   require_serial: true
   pass_filenames: false
+- id: golangci-lint-full
+  name: golangci-lint-full
+  description: Fast linters runner for Go. Runs on all files in the repo. Use this hook if you use pre-commit in CI.
+  entry: golangci-lint run --fix
+  types: [go]
+  language: golang
+  require_serial: true
+  pass_filenames: false

go.mod

@@ -79,10 +79,10 @@ require (
 	github.com/nishanths/exhaustive v0.11.0
 	github.com/nishanths/predeclared v0.2.2
 	github.com/nunnatsa/ginkgolinter v0.13.5
-	github.com/polyfloyd/go-errorlint v1.4.4
+	github.com/polyfloyd/go-errorlint v1.4.5
 	github.com/quasilyte/go-ruleguard/dsl v0.3.22
 	github.com/ryancurrah/gomodguard v1.3.0
-	github.com/ryanrolds/sqlclosecheck v0.4.0
+	github.com/ryanrolds/sqlclosecheck v0.5.1
 	github.com/sanposhiho/wastedassign/v2 v2.0.7
 	github.com/sashamelentyev/interfacebloat v1.1.0
 	github.com/sashamelentyev/usestdlibvars v1.24.0
@@ -102,7 +102,7 @@ require (
 	github.com/stbenjam/no-sprintf-host-port v0.1.1
 	github.com/stretchr/testify v1.8.4
 	github.com/tdakkota/asciicheck v0.2.0
-	github.com/tetafro/godot v1.4.14
+	github.com/tetafro/godot v1.4.15
 	github.com/timakin/bodyclose v0.0.0-20230421092635-574207250966
 	github.com/timonwong/loggercheck v0.9.4
 	github.com/tomarrell/wrapcheck/v2 v2.8.1
@@ -120,7 +120,7 @@ require (
 	golang.org/x/exp v0.0.0-20230510235704-dd950f8aeaea
 	golang.org/x/tools v0.13.0
 	gopkg.in/yaml.v3 v3.0.1
-	honnef.co/go/tools v0.4.5
+	honnef.co/go/tools v0.4.6
 	mvdan.cc/gofumpt v0.5.0
 	mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed
 	mvdan.cc/unparam v0.0.0-20221223090309-7455f1af531d

go.sum

@@ -4,13 +4,13 @@ go 1.19
 
 require (
 	github.com/shurcooL/githubv4 v0.0.0-20230215024106-420ad0987b9b
-	golang.org/x/oauth2 v0.11.0
+	golang.org/x/oauth2 v0.12.0
 )
 
 require (
 	github.com/golang/protobuf v1.5.3 // indirect
 	github.com/shurcooL/graphql v0.0.0-20220606043923-3cf50f8a0a29 // indirect
-	golang.org/x/net v0.14.0 // indirect
+	golang.org/x/net v0.15.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
 	google.golang.org/protobuf v1.31.0 // indirect
 )

scripts/gen_github_action_config/go.mod

@@ -68,7 +68,7 @@ func rowsCorrectDefer() {
 }
 
 func rowsMissingClose() {
-	rows, err := db.QueryContext(ctx, "SELECT name FROM users WHERE age=?", age) // want "Rows/Stmt was not closed"
+	rows, err := db.QueryContext(ctx, "SELECT name FROM users WHERE age=?", age) // want "Rows/Stmt/NamedStmt was not closed"
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -91,7 +91,7 @@ func rowsMissingClose() {
 }
 
 func rowsMissingCloseG[T ~int64](db *sql.DB, a T) {
-	rows, _ := db.Query("select id from tb") // want "Rows/Stmt was not closed"
+	rows, _ := db.Query("select id from tb") // want "Rows/Stmt/NamedStmt was not closed"
 	for rows.Next() {
 		// ...
 	}
@@ -208,7 +208,7 @@ func stmtCorrectDefer() {
 
 func stmtMissingClose() {
 	// In normal use, create one Stmt when your process starts.
-	stmt, err := db.PrepareContext(ctx, "SELECT username FROM users WHERE id = ?") // want "Rows/Stmt was not closed"
+	stmt, err := db.PrepareContext(ctx, "SELECT username FROM users WHERE id = ?") // want "Rows/Stmt/NamedStmt was not closed"
 	if err != nil {
 		log.Fatal(err)
 	}