review: simplify

Author: ldez

pkg/golinters/importas/importas.go

@@ -51,15 +51,12 @@ func New(settings *config.ImportAsSettings) *goanalysis.Linter {
 				uniqPackages[a.Pkg] = a
 			}
 
-			// Ignore duplication for empty aliases.
-			if a.Alias != "" {
-				// skip the duplication check when the alias is a regular expression replacement pattern (ie. contains `$`).
-				v, ok := uniqAliases[a.Alias]
-				if ok && !strings.Contains(a.Alias, "$") {
-					lintCtx.Log.Errorf("invalid configuration, multiple packages with the same alias: alias=%s packages=[%s,%s]", a.Alias, a.Pkg, v.Pkg)
-				} else {
-					uniqAliases[a.Alias] = a
-				}
+			// skip the duplication check when the alias is a regular expression replacement pattern (ie. contains `$`).
+			v, ok := uniqAliases[a.Alias]
+			if ok && !strings.Contains(a.Alias, "$") {
+				lintCtx.Log.Errorf("invalid configuration, multiple packages with the same alias: alias=%s packages=[%s,%s]", a.Alias, a.Pkg, v.Pkg)
+			} else if a.Alias != "" { // Ignore duplication for empty aliases.
+				uniqAliases[a.Alias] = a
 			}
 
 			err := analyzer.Flags.Set("alias", fmt.Sprintf("%s:%s", a.Pkg, a.Alias))