Skip to content

Commit 5218ad2

Browse files
remove nolint for stylecheck
1 parent e523e64 commit 5218ad2

File tree

8 files changed

+17
-16
lines changed

8 files changed

+17
-16
lines changed

go.sum

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/config/config.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,11 @@ var DefaultExcludePatterns = []ExcludePattern{
100100
Why: "False positive is triggered by 'src, err := ioutil.ReadFile(filename)'",
101101
},
102102
{
103-
ID: "EXC0011",
104-
Pattern: "at least one file in a package should have a package comment",
105-
Linter: "stylecheck",
106-
Why: "Annoying issue about not having a package comment.",
103+
ID: "EXC0011",
104+
Pattern: "(comment on exported (method|function|type|const)|" +
105+
"should have( a package)? comment|comment should be of the form)",
106+
Linter: "stylecheck",
107+
Why: "Annoying issue about not having a comment. The rare codebase has such comments",
107108
},
108109
}
109110

pkg/golinters/gocognit.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// nolint:dupl
2-
// nolint:stylecheck
32
package golinters
43

54
import (

pkg/golinters/gocyclo.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// nolint:dupl
2-
// nolint:stylecheck
32
package golinters
43

54
import (

pkg/lint/lintersdb/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func enableLinterConfigs(lcs []*linter.Config, isEnabled func(lc *linter.Config)
8585
return ret
8686
}
8787

88-
//nolint:funlen,stylecheck
88+
//nolint:funlen
8989
func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
9090
var govetCfg *config.GovetSettings
9191
var testpackageCfg *config.TestpackageSettings

pkg/packages/errors.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99
"github.com/pkg/errors"
1010
)
1111

12-
//nolint:gomnd,stylecheck
12+
//nolint:gomnd
1313
func ParseErrorPosition(pos string) (*token.Position, error) {
1414
// file:line(<optional>:colon)
1515
parts := strings.Split(pos, ":")

pkg/result/processors/sort_results.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ var (
9191

9292
type ByName struct{ next comparator }
9393

94-
//nolint:golint,stylecheck
94+
//nolint:golint
9595
func (cmp ByName) Next() comparator { return cmp.next }
9696

97-
//nolint:golint,stylecheck
97+
//nolint:golint
9898
func (cmp ByName) Compare(a, b *result.Issue) compareResult {
9999
var res compareResult
100100

@@ -111,10 +111,10 @@ func (cmp ByName) Compare(a, b *result.Issue) compareResult {
111111

112112
type ByLine struct{ next comparator }
113113

114-
//nolint:golint,stylecheck
114+
//nolint:golint
115115
func (cmp ByLine) Next() comparator { return cmp.next }
116116

117-
//nolint:golint,stylecheck
117+
//nolint:golint
118118
func (cmp ByLine) Compare(a, b *result.Issue) compareResult {
119119
var res compareResult
120120

@@ -131,10 +131,10 @@ func (cmp ByLine) Compare(a, b *result.Issue) compareResult {
131131

132132
type ByColumn struct{ next comparator }
133133

134-
//nolint:golint,stylecheck
134+
//nolint:golint
135135
func (cmp ByColumn) Next() comparator { return cmp.next }
136136

137-
//nolint:golint,stylecheck
137+
//nolint:golint
138138
func (cmp ByColumn) Compare(a, b *result.Issue) compareResult {
139139
var res compareResult
140140

test/testdata/stylecheck.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
//args: -Estylecheck
2-
3-
/* Package testdata ... */
42
package testdata
53

64
func Stylecheck(x int) {

0 commit comments

Comments
 (0)