feat: add interfacebloat

Author: sashamelentyev

.golangci.reference.yml

@@ -1072,6 +1072,9 @@ linters-settings:
       - pkg: knative.dev/serving/pkg/apis/(\w+)/(v[\w\d]+)
         alias: $1$2
 
+  interfacebloat:
+    interface-len: 10
+
   ireturn:
     # ireturn allows using `allow` and `reject` settings at the same time.
     # Both settings are lists of the keywords and regular expressions matched to interface or package names.
@@ -1921,6 +1924,7 @@ linters:
     - ifshort
     - importas
     - ineffassign
+    - interfacebloat
     - interfacer
     - ireturn
     - lll
@@ -2023,6 +2027,7 @@ linters:
     - ifshort
     - importas
     - ineffassign
+    - interfacebloat
     - interfacer
     - ireturn
     - lll

go.mod

@@ -74,6 +74,7 @@ require (
 	github.com/ryancurrah/gomodguard v1.2.4
 	github.com/ryanrolds/sqlclosecheck v0.3.0
 	github.com/sanposhiho/wastedassign/v2 v2.0.6
+	github.com/sashamelentyev/interfacebloat v1.0.0
 	github.com/sashamelentyev/usestdlibvars v1.10.0
 	github.com/securego/gosec/v2 v2.12.0
 	github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c

go.sum

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/sashamelentyev/interfacebloat/pkg/analyzer"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewInterfaceBloat() *goanalysis.Linter {
+	a := analyzer.New()
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	)
+}

pkg/golinters/interfacebloat.go

@@ -557,6 +557,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetUnused).
 			WithURL("https://github.com/gordonklaus/ineffassign"),
 
+		linter.NewConfig(golinters.NewInterfaceBloat()).
+			WithSince("v1.48.0").
+			WithLoadForGoAnalysis().
+			WithPresets(linter.PresetStyle).
+			WithURL("https://github.com/sashamelentyev/interfacebloat"),
+
 		linter.NewConfig(golinters.NewInterfacer()).
 			WithSince("v1.0.0").
 			WithLoadForGoAnalysis().

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,48 @@
+//golangcitest:args -Einterfacebloat
+package testdata
+
+type _ interface { // want "length of interface greater than 10"
+	a()
+	b()
+	c()
+	d()
+	f()
+	g()
+	h()
+	i()
+	j()
+	k()
+	l()
+}
+
+func _() {
+	var _ interface { // want "length of interface greater than 10"
+		a()
+		b()
+		c()
+		d()
+		f()
+		g()
+		h()
+		i()
+		j()
+		k()
+		l()
+	}
+}
+
+func __() interface { // want "length of interface greater than 10"
+	a()
+	b()
+	c()
+	d()
+	f()
+	g()
+	h()
+	i()
+	j()
+	k()
+	l()
+} {
+	return nil
+}