fix #1404: integrate looppointer

Author: kamilsk

go.mod

@@ -42,6 +42,7 @@ require (
 	github.com/kulti/thelper v0.4.0
 	github.com/kunwardeep/paralleltest v1.0.2
 	github.com/kyoh86/exportloopref v0.1.8
+	github.com/kyoh86/looppointer v0.1.7
 	github.com/ldez/gomoddirectives v0.2.1
 	github.com/ldez/tagliatelle v0.2.0
 	github.com/maratori/testpackage v1.0.1

go.sum

@@ -0,0 +1,21 @@
+package golinters
+
+import (
+	"github.com/kyoh86/looppointer"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+// NewLoopPointer returns a new instance of Linter based on
+// github.com/kyoh86/looppointer.
+func NewLoopPointer() *goanalysis.Linter {
+	analyzer := looppointer.Analyzer
+
+	return goanalysis.NewLinter(
+		analyzer.Name,
+		analyzer.Doc,
+		[]*analysis.Analyzer{analyzer},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/looppointer.go

@@ -488,6 +488,10 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithSince("v1.40.0").
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/ldez/tagliatelle"),
+		linter.NewConfig(golinters.NewLoopPointer()).
+			WithSince("v1.40.0").
+			WithPresets(linter.PresetBugs).
+			WithURL("https://github.com/kyoh86/looppointer"),
 
 		// nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives
 		linter.NewConfig(golinters.NewNoLintLint()).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,34 @@
+//args: -Elooppointer
+package testdata
+
+func lintLoopPointer() {
+	type domain struct {
+		property *int
+	}
+
+	type dto struct {
+		prop int
+		cond bool
+	}
+
+	result := make([]domain, 0, 3)
+	for _, d := range []dto{
+		{prop: 10},
+		{prop: 11},
+		{prop: 12},
+	} {
+		p := domain{}
+		if !d.cond {
+			p.property = &d.prop // ERROR "taking a pointer for the loop variable d"
+		}
+		result = append(result, p)
+	}
+
+	for _, r := range result {
+		if r.property != nil {
+			// expected 10, 11, 12
+			// obtained 12, 12, 12
+			println(*r.property)
+		}
+	}
+}