Skip to content

Commit 152c26e

Browse files
committed
fix default configuration
1 parent 551e581 commit 152c26e

File tree

3 files changed

+40
-4
lines changed

3 files changed

+40
-4
lines changed

pkg/config/linters_settings.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,10 @@ var defaultLintersSettings = LintersSettings{
159159
SkipRegexp: `(export|internal)_test\.go`,
160160
AllowPackages: []string{"main"},
161161
},
162+
Ttempdir: TtempdirSettings{
163+
All: false,
164+
MaxRecursionLevel: 5,
165+
},
162166
Unparam: UnparamSettings{
163167
Algo: "cha",
164168
},

pkg/golinters/ttempdir/testdata/ttempdir.go renamed to pkg/golinters/ttempdir/testdata/os_mkdirtemp_test.go

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
//golangcitest:args -Ettempdir
2-
//golangcitest:config_path testdata/ttempdir_all.yml
32
package testdata
43

54
import (
5+
"fmt"
66
"os"
77
"testing"
88
)
@@ -12,12 +12,12 @@ var (
1212
)
1313

1414
func testsetup() {
15-
os.MkdirTemp("a", "b") // if -all = true, want "os\\.MkdirTemp\\(\\) should be replaced by `testing\\.TempDir\\(\\)` in testsetup"
16-
_, err := os.MkdirTemp("a", "b") // if -all = true, want "os\\.MkdirTemp\\(\\) should be replaced by `testing\\.TempDir\\(\\)` in testsetup"
15+
os.MkdirTemp("a", "b") // never seen
16+
_, err := os.MkdirTemp("a", "b") // never seen
1717
if err != nil {
1818
_ = err
1919
}
20-
os.MkdirTemp("a", "b") // if -all = true, "func setup is not using testing.TempDir"
20+
os.MkdirTemp("a", "b") // never seen
2121
}
2222

2323
func TestF(t *testing.T) {
@@ -77,3 +77,31 @@ func TestEmpty(t *testing.T) {
7777
func TestEmptyTB(t *testing.T) {
7878
func(testing.TB) {}(t)
7979
}
80+
81+
func TestTDD(t *testing.T) {
82+
for _, tt := range []struct {
83+
name string
84+
}{
85+
{"test"},
86+
} {
87+
t.Run(tt.name, func(t *testing.T) {
88+
os.MkdirTemp("a", "b") // want "os\\.MkdirTemp\\(\\) should be replaced by `t\\.TempDir\\(\\)` in anonymous function"
89+
_, err := os.MkdirTemp("a", "b") // want "os\\.MkdirTemp\\(\\) should be replaced by `t\\.TempDir\\(\\)` in anonymous function"
90+
_ = err
91+
if _, err := os.MkdirTemp("a", "b"); err != nil { // want "os\\.MkdirTemp\\(\\) should be replaced by `t\\.TempDir\\(\\)` in anonymous function"
92+
_ = err
93+
}
94+
})
95+
}
96+
}
97+
98+
func TestLoop(t *testing.T) {
99+
for i := 0; i < 3; i++ {
100+
os.MkdirTemp(fmt.Sprintf("a%d", i), "b") // want "os\\.MkdirTemp\\(\\) should be replaced by `t\\.TempDir\\(\\)` in TestLoop"
101+
_, err := os.MkdirTemp(fmt.Sprintf("a%d", i), "b") // want "os\\.MkdirTemp\\(\\) should be replaced by `t\\.TempDir\\(\\)` in TestLoop"
102+
_ = err
103+
if _, err := os.MkdirTemp(fmt.Sprintf("a%d", i), "b"); err != nil { // want "os\\.MkdirTemp\\(\\) should be replaced by `t\\.TempDir\\(\\)` in TestLoop"
104+
_ = err
105+
}
106+
}
107+
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
linters-settings:
2+
ttempdir:
3+
all: false
4+
max-recursion-level: 10

0 commit comments

Comments
 (0)