gopls/internal/lsp/cache: don't trace a region for MetadataForFile

findleyr · findleyr · commit d5076cc64d48 · 2023-04-04T02:28:45.000Z
In the common case, MetadataForFile is just a map lookup. Benchmarks demonstrate that capturing a trace region is too expensive. Change-Id: I02d2b65de88f5db37beb16fba034e3c49c5f6096 Reviewed-on: https://go-review.googlesource.com/c/tools/+/481785 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com>
diff --git a/gopls/internal/lsp/cache/snapshot.go b/gopls/internal/lsp/cache/snapshot.go
@@ -740,9 +740,6 @@ func (s *snapshot) MethodSets(ctx context.Context, ids ...PackageID) ([]*methods
 }
 
 func (s *snapshot) MetadataForFile(ctx context.Context, uri span.URI) ([]*source.Metadata, error) {
-	ctx, done := event.Start(ctx, "cache.snapshot.MetadataForFile")
-	defer done()
-
 	s.mu.Lock()
 
 	// Start with the set of package associations derived from the last load.

Original file line number	Diff line number	Diff line change
`@@ -740,9 +740,6 @@ func (s snapshot) MethodSets(ctx context.Context, ids ...PackageID) ([]methods`
`740`	`740`	`}`
`741`	`741`
`742`	`742`	`func (s snapshot) MetadataForFile(ctx context.Context, uri span.URI) ([]source.Metadata, error) {`
`743`		`- ctx, done := event.Start(ctx, "cache.snapshot.MetadataForFile")`
`744`		`- defer done()`
`745`		`-`
`746`	`743`	`s.mu.Lock()`
`747`	`744`
`748`	`745`	`// Start with the set of package associations derived from the last load.`