Skip to content

Commit fd8a559

Browse files
committed
moved checking canceled logic into method of connection.
1 parent 41940ff commit fd8a559

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

connection.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,16 @@ func (mc *mysqlConn) isBroken() bool {
134134
return mc.closed
135135
}
136136

137+
func (mc *mysqlConn) error() error {
138+
if mc.isBroken() {
139+
if err := mc.canceled(); err != nil {
140+
return err
141+
}
142+
return ErrInvalidConn
143+
}
144+
return nil
145+
}
146+
137147
func (mc *mysqlConn) Prepare(query string) (driver.Stmt, error) {
138148
if mc.isBroken() {
139149
errLog.Print(ErrInvalidConn)

rows.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,8 @@ func (rows *binaryRows) NextResultSet() error {
161161

162162
func (rows *binaryRows) Next(dest []driver.Value) error {
163163
if mc := rows.mc; mc != nil {
164-
if mc.isBroken() {
165-
if err := mc.canceled(); err != nil {
166-
return err
167-
}
168-
return ErrInvalidConn
164+
if err := mc.error(); err != nil {
165+
return err
169166
}
170167

171168
// Fetch next row from stream
@@ -186,11 +183,8 @@ func (rows *textRows) NextResultSet() (err error) {
186183

187184
func (rows *textRows) Next(dest []driver.Value) error {
188185
if mc := rows.mc; mc != nil {
189-
if mc.isBroken() {
190-
if err := mc.canceled(); err != nil {
191-
return err
192-
}
193-
return ErrInvalidConn
186+
if err := mc.error(); err != nil {
187+
return err
194188
}
195189

196190
// Fetch next row from stream

0 commit comments

Comments
 (0)