CI-friendly golden testing fixes

Author: Drew O'Meara

examples/embedding/main_test.go

@@ -2,27 +2,33 @@ package main
 
 import (
 	"bytes"
+	"flag"
 	"os"
 	"os/exec"
+	"path/filepath"
 	"testing"
 )
 
-const embeddingTestOutput = "testdata/embedding_golden.txt"
+const embeddingTestOutput = "testdata/embedding_out_golden.txt"
+
 var regen = flag.Bool("regen", false, "regenerate golden files")
 
 func TestEmbeddedExample(t *testing.T) {
 
 	tmp, err := os.MkdirTemp("", "go-python-embedding-")
-	if err != nil { t.Fatal(err) }
+	if err != nil {
+		t.Fatal(err)
+	}
 	defer os.RemoveAll(tmp)
-	cmd := exec.Command("go", "build", "-o", filepath.Join(tmp,"exe"), ".")
-	err := cmd.Run()
+
+	cmd := exec.Command("go", "build", "-o", filepath.Join(tmp, "exe"), ".")
+	err = cmd.Run()
 	if err != nil {
 		t.Fatalf("failed to compile embedding example: %v", err)
 	}
 
 	out := new(bytes.Buffer)
-	cmd = exec.Command(filepath.Join(tmp,"exe"), "mylib-demo.py")
+	cmd = exec.Command(filepath.Join(tmp, "exe"), "mylib-demo.py")
 	cmd.Stdout = out
 
 	err = cmd.Run()
@@ -31,17 +37,20 @@ func TestEmbeddedExample(t *testing.T) {
 	}
 
 	testOutput := out.Bytes()
+
+	flag.Parse()
 	if *regen {
 		err = os.WriteFile(embeddingTestOutput, testOutput, 0644)
 		if err != nil {
 			t.Fatalf("failed to write test output: %v", err)
 		}
 	}
-		mustMatch, err := os.ReadFile(embeddingTestOutput)
-		if err != nil {
-			t.Fatalf("failed read %q", embeddingTestOutput)
-		}
-		if !bytes.Equal(testOutput, mustMatch) {
-			t.Fatalf("embedded test output did not match accepted output from %q", embeddingTestOutput)
-		}
+
+	mustMatch, err := os.ReadFile(embeddingTestOutput)
+	if err != nil {
+		t.Fatalf("failed read %q", embeddingTestOutput)
+	}
+	if !bytes.Equal(testOutput, mustMatch) {
+		t.Fatalf("embedded test output did not match accepted output from %q", embeddingTestOutput)
+	}
 }

examples/embedding/embedding-test-output.txt renamed to examples/embedding/testdata/embedding_out_golden.txt

@@ -12,7 +12,7 @@ Spring Break itinerary:
     Stop 2:   Mallorca, Spain   |   3 nights
     Stop 3:   Ibiza, Spain      |  14 nights
     Stop 4:   Monaco            |  12 nights
-###  Made with Vacaton 1.0 by Fletch F. Fletcher 
+###  Made with Vacation 1.0 by Fletch F. Fletcher 
 
 I bet Monaco will be the best!