Skip to content

Commit 98c1450

Browse files
WangXiangUSTCsiddontang
authored andcommitted
add assert of response code, and fix the bug of parent test (#110)
1 parent 6323e6b commit 98c1450

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

elastic/client_test.go

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ func (s *elasticTestSuite) TestSimple(c *C) {
5353

5454
r, err := s.c.Get(index, docType, "1")
5555
c.Assert(err, IsNil)
56+
c.Assert(r.Code, Equals, 200)
5657
c.Assert(r.ID, Equals, "1")
5758

5859
err = s.c.Delete(index, docType, "1")
@@ -78,6 +79,7 @@ func (s *elasticTestSuite) TestSimple(c *C) {
7879

7980
resp, err := s.c.IndexTypeBulk(index, docType, items)
8081
c.Assert(err, IsNil)
82+
c.Assert(resp.Code, Equals, 200)
8183
c.Assert(resp.Errors, Equals, false)
8284

8385
for i := 0; i < 10; i++ {
@@ -90,16 +92,26 @@ func (s *elasticTestSuite) TestSimple(c *C) {
9092

9193
resp, err = s.c.IndexTypeBulk(index, docType, items)
9294
c.Assert(err, IsNil)
95+
c.Assert(resp.Code, Equals, 200)
9396
c.Assert(resp.Errors, Equals, false)
9497
}
9598

9699
// this requires a parent setting in _mapping
97100
func (s *elasticTestSuite) TestParent(c *C) {
98101
index := "dummy"
99102
docType := "comment"
103+
ParentType := "parent"
100104

105+
mapping := map[string]interface{}{
106+
docType: map[string]interface{}{
107+
"_parent": map[string]string{"type": ParentType},
108+
},
109+
}
110+
err := s.c.CreateMapping(index, docType, mapping)
111+
c.Assert(err, IsNil)
112+
101113
items := make([]*BulkRequest, 10)
102-
114+
103115
for i := 0; i < 10; i++ {
104116
id := fmt.Sprintf("%d", i)
105117
req := new(BulkRequest)
@@ -112,16 +124,20 @@ func (s *elasticTestSuite) TestParent(c *C) {
112124

113125
resp, err := s.c.IndexTypeBulk(index, docType, items)
114126
c.Assert(err, IsNil)
127+
c.Assert(resp.Code, Equals, 200)
115128
c.Assert(resp.Errors, Equals, false)
116-
117129
for i := 0; i < 10; i++ {
118130
id := fmt.Sprintf("%d", i)
119131
req := new(BulkRequest)
132+
req.Index = index
133+
req.Type = docType
120134
req.Action = ActionDelete
121135
req.ID = id
136+
req.Parent = "1"
122137
items[i] = req
123138
}
124-
resp, err = s.c.IndexTypeBulk(index, docType, items)
139+
resp, err = s.c.Bulk(items)
125140
c.Assert(err, IsNil)
141+
c.Assert(resp.Code, Equals, 200)
126142
c.Assert(resp.Errors, Equals, false)
127143
}

0 commit comments

Comments
 (0)