-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Documentation add timezone and localtime volumes to Docker Guide #8911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation add timezone and localtime volumes to Docker Guide #8911
Conversation
Passing these volumes to the container enable gitea to use hosts localtime and timezone. This is a mandatory change when using the "Setup fail2ban" Guide, but it is not described in the documentation.
In question of the documentation change being added to the docker guide or the fail2ban guide, like the original reported of the issue, i think that using hosts /etc/timezone and /etc/localtime in the container should be considered, even if not using fail2ban |
Codecov Report
@@ Coverage Diff @@
## master #8911 +/- ##
=========================================
Coverage ? 41.28%
=========================================
Files ? 546
Lines ? 71005
Branches ? 0
=========================================
Hits ? 29313
Misses ? 37975
Partials ? 3717 Continue to review full report at Codecov.
|
This pull request adds timezone and localtime volumes to the Installation with Docker guide.
Passing these volumes to the container enable gitea to use hosts localtime and timezone.
This is a mandatory change when using the Fail2ban setup to block users after failed login attemts Guide, but it is not described in the documentation. If not set up correctly, a user will experience the following fail2ban behaviour:
Testing with fail2ban-regex will report a valid regex filter.
sudo fail2ban-regex ./gitea/log/gitea.log /etc/fail2ban/filter.d/gitea.conf
On failed authentication attempt, in certain time configurations, fail2ban will not report the failed attempt, neither will increment the failure detection count or proceed to ban the offender after n tries.
This issue was reported in the past (6421), it seems the issue was forgotten but the described problems still apply today.