Skip to content

Documentation add timezone and localtime volumes to Docker Guide #8911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2019
Merged

Documentation add timezone and localtime volumes to Docker Guide #8911

merged 4 commits into from
Nov 13, 2019

Conversation

h00000000
Copy link
Contributor

This pull request adds timezone and localtime volumes to the Installation with Docker guide.
Passing these volumes to the container enable gitea to use hosts localtime and timezone.

This is a mandatory change when using the Fail2ban setup to block users after failed login attemts Guide, but it is not described in the documentation. If not set up correctly, a user will experience the following fail2ban behaviour:

Testing with fail2ban-regex will report a valid regex filter.
sudo fail2ban-regex ./gitea/log/gitea.log /etc/fail2ban/filter.d/gitea.conf

On failed authentication attempt, in certain time configurations, fail2ban will not report the failed attempt, neither will increment the failure detection count or proceed to ban the offender after n tries.

This issue was reported in the past (6421), it seems the issue was forgotten but the described problems still apply today.

Passing these volumes to the container enable gitea to use hosts localtime and timezone.
This is a mandatory change when using the "Setup fail2ban" Guide, but it is not described in the documentation.
@h00000000
Copy link
Contributor Author

In question of the documentation change being added to the docker guide or the fail2ban guide, like the original reported of the issue, i think that using hosts /etc/timezone and /etc/localtime in the container should be considered, even if not using fail2ban

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2019
h00000000 pushed a commit to h00000000/docker-stuff that referenced this pull request Nov 10, 2019
@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@be869e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8911   +/-   ##
=========================================
  Coverage          ?   41.28%           
=========================================
  Files             ?      546           
  Lines             ?    71005           
  Branches          ?        0           
=========================================
  Hits              ?    29313           
  Misses            ?    37975           
  Partials          ?     3717

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be869e8...17aa975. Read the comment docs.

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Nov 11, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 11, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 13, 2019
@zeripath zeripath merged commit 27ac1d0 into go-gitea:master Nov 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants