From 8e4318088650107b1ba63418e3a01dc02ddfa495 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Sun, 1 Sep 2024 17:20:56 +0200 Subject: [PATCH 1/4] we control the sort input for our own webui --- routers/web/explore/repo.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/routers/web/explore/repo.go b/routers/web/explore/repo.go index ab487dff5fcbc..62090e5bf4dba 100644 --- a/routers/web/explore/repo.go +++ b/routers/web/explore/repo.go @@ -6,7 +6,6 @@ package explore import ( "fmt" "net/http" - "strings" "code.gitea.io/gitea/models/db" repo_model "code.gitea.io/gitea/models/repo" @@ -58,7 +57,7 @@ func RenderRepoSearch(ctx *context.Context, opts *RepoSearchOptions) { orderBy db.SearchOrderBy ) - sortOrder := strings.ToLower(ctx.FormString("sort")) + sortOrder := ctx.FormString("sort") if sortOrder == "" { sortOrder = setting.UI.ExploreDefaultSort } From 104ce1be600f36c5e52a251add9375a23d0402c8 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Sun, 1 Sep 2024 17:23:07 +0200 Subject: [PATCH 2/4] api: url sort option should be case insensitive --- routers/api/v1/repo/repo.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/routers/api/v1/repo/repo.go b/routers/api/v1/repo/repo.go index 1bcec8fcf7e72..8518bfbdc87ef 100644 --- a/routers/api/v1/repo/repo.go +++ b/routers/api/v1/repo/repo.go @@ -178,7 +178,8 @@ func Search(ctx *context.APIContext) { opts.IsPrivate = optional.Some(ctx.FormBool("is_private")) } - sortMode := ctx.FormString("sort") + // as sort is an url param, we should be case insensitive + sortMode := strings.ToLower(ctx.FormString("sort")) if len(sortMode) > 0 { sortOrder := ctx.FormString("order") if len(sortOrder) == 0 { From 4ddbe9a0e9d674011c991f33c096d886a01dd9ba Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Thu, 5 Sep 2024 12:20:38 +0200 Subject: [PATCH 3/4] for the sake of consistency --- routers/api/v1/repo/repo.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routers/api/v1/repo/repo.go b/routers/api/v1/repo/repo.go index 8518bfbdc87ef..c305752b97d5e 100644 --- a/routers/api/v1/repo/repo.go +++ b/routers/api/v1/repo/repo.go @@ -179,7 +179,7 @@ func Search(ctx *context.APIContext) { } // as sort is an url param, we should be case insensitive - sortMode := strings.ToLower(ctx.FormString("sort")) + sortMode := ctx.FormString("sort") if len(sortMode) > 0 { sortOrder := ctx.FormString("order") if len(sortOrder) == 0 { From 107b0472a1876f124528f2fd581c0f5e34c5f001 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Thu, 5 Sep 2024 12:21:37 +0200 Subject: [PATCH 4/4] clean --- routers/api/v1/repo/repo.go | 1 - 1 file changed, 1 deletion(-) diff --git a/routers/api/v1/repo/repo.go b/routers/api/v1/repo/repo.go index c305752b97d5e..1bcec8fcf7e72 100644 --- a/routers/api/v1/repo/repo.go +++ b/routers/api/v1/repo/repo.go @@ -178,7 +178,6 @@ func Search(ctx *context.APIContext) { opts.IsPrivate = optional.Some(ctx.FormBool("is_private")) } - // as sort is an url param, we should be case insensitive sortMode := ctx.FormString("sort") if len(sortMode) > 0 { sortOrder := ctx.FormString("order")