From 06d38e4704799d576696b74a6a82cd9756175a01 Mon Sep 17 00:00:00 2001 From: Kyle D Date: Wed, 10 May 2023 19:05:25 -0400 Subject: [PATCH 1/2] Fix redis unit check to test if CI --- modules/queue/base_redis_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/queue/base_redis_test.go b/modules/queue/base_redis_test.go index 3d49e8d98c5fb..19fbccbc8fe75 100644 --- a/modules/queue/base_redis_test.go +++ b/modules/queue/base_redis_test.go @@ -56,7 +56,7 @@ func TestBaseRedis(t *testing.T) { }() if !waitRedisReady("redis://127.0.0.1:6379/0", 0) { redisServer = redisServerCmd(t) - if redisServer == nil && os.Getenv("CI") != "" { + if redisServer == nil && os.Getenv("CI") == "" { t.Skip("redis-server not found") return } From f9cbc8f0c024af2de4518761750620c6a3e053dc Mon Sep 17 00:00:00 2001 From: Kyle D Date: Wed, 10 May 2023 19:05:25 -0400 Subject: [PATCH 2/2] Add minio for unit tests --- .github/workflows/pull-db_test.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/pull-db_test.yml b/.github/workflows/pull-db_test.yml index ce97bfcb2c0f8..243499b611fb2 100644 --- a/.github/workflows/pull-db_test.yml +++ b/.github/workflows/pull-db_test.yml @@ -110,6 +110,16 @@ jobs: - "143:143" - "587:587" - "993:993" + redis: + image: redis + # Set health checks to wait until redis has started + options: >- + --health-cmd "redis-cli ping" + --health-interval 5s + --health-timeout 3s + --health-retries 10 + ports: + - 6379:6379 steps: - name: checkout uses: actions/checkout@v3